Use java.nio.file.Path in CoursierPaths instead of java.io.File #3364
Conversation
|
Hi @vasilmkd, about these changes, I assume you'd like the methods returning I've been wanting to switch entirely to NIO already. I ran into some issues, so I didn't fully make the switch (#3120, #3132 are merged, while #3124 isn't). Could you not deprecate the methods returning |
Ideally, yes. I assume you're referring to other usages of
Of course! This is exactly why I opened this PR as a draft. I will push the change as soon as possible. |
…ith the real Coursier API #SCL-23312 - I upstreamed the changes that we had made to our own copy of CoursierPaths (java.io.File -> java.nio.file.Path migration). - coursier/coursier#3364 - We need to update the version again when the non-milestone artifact is released.
Hello. The Scala Plugin for IDEA has a copy of the CoursierPaths source code in our project.
https://github.com/JetBrains/intellij-scala/blob/idea251.x/scala/scala-impl/src/org/jetbrains/plugins/scala/project/sdkdetect/repository/CoursierPaths.java
I'd like to remove this copy and use the version provided by coursier directly, since coursier is itself a dependency of the Scala Plugin for IDEA.
Unfortunately, we've recently started a migration to
java.nio.file.Pathand away fromjava.io.File. This will be necessary for proper support of remote development and WSL support in IDEA. Ideally, the CoursierPaths implementation would also usejava.nio.file.Pathbehind the scenes.This draft PR is the first step towards that, to kickstart the process. As an initial idea, I've added new methods which return a
java.nio.file.Pathand deprecated the already existing methods returning ajava.io.File. I've also replaced the private implementation withjava.nio.file.Path. I've not touched anything else.Should we continue along this way, or do you have some other suggestions? Thank you.