8000 [postgres] remove douplicated template from backup manifest by etoshutka · Pull Request #872 · cozystack/cozystack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[postgres] remove douplicated template from backup manifest #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

[postgres] remove douplicated template from backup manifest #872

merged 1 commit into from
Apr 24, 2025

Conversation

etoshutka
Copy link
Contributor
@etoshutka etoshutka commented Apr 24, 2025 •
edited by coderabbitai bot
Loading

Resolves #869

Summary by CodeRabbit

  • Refactor
    • Updated backup cron job configuration for improved clarity and structure. No changes to backup behavior or scheduling.
  • Chores
    • Incremented the application chart version to 0.10.1.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 24, 2025 •
edited
Loading

Warning

Rate limit exceeded

@kvaps has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 18 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a6afdaf and 19409d8.

📒 Files selected for processing (3)
  • packages/apps/postgres/Chart.yaml (1 hunks)
  • packages/apps/postgres/templates/backup-cronjob.yaml (1 hunks)
  • packages/apps/versions_map (1 hunks)

"""

Walkthrough

The change involves editing a Kubernetes YAML template for a PostgreSQL backup cron job. Specifically, the restartPolicy: OnFailure field and its parent template and spec keys were removed from the job template section. The remaining configuration, including metadata annotations and pod specifications, was left unchanged. Additionally, the Helm chart version for the PostgreSQL application was incremented from 0.10.0 to 0.10.1. No modifications were made to exported or public entities.

Changes

File(s) Change Summary
packages/apps/postgres/templates/backup-cronjob.yaml Removed duplicate template and nested spec containing restartPolicy: OnFailure from the job template to fix YAML parsing errors. No other changes made.
packages/apps/postgres/Chart.yaml Incremented Helm chart version from 0.10.0 to 0.10.1. No other changes.

Assessment against linked issues

Objective Addressed Explanation
Remove duplicate template key causing YAML unmarshal errors (#869) ✅

Poem

A YAML line hops out of view,
No more restart on failure to do.
The cron job’s lighter, neat and clean,
With simpler fields now in between.
A rabbit cheers this tidy feat—
Less clutter makes the config sweet!
🐇✨
"""

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps
Copy link
Member
kvaps commented Apr 24, 2025

Hey @etoshutka many thanks for your contribution, could you please fix DCO?

git commit --amend -s
git push -f

@kvaps kvaps added the backport Should change be backported on previus release label Apr 24, 2025
@kvaps
Copy link
Member
kvaps commented Apr 24, 2025 •
edited
Loading

@etoshutka please also bump patch version to 0.10.1 here:

cozystack/packages/apps/postgres/Chart.yaml

Line 19 in 1d2ccbd

version: 0.10.0

and run make gen-versions-map from /packages/apps to update the version

@etoshutka
Copy link
Contributor Author

@etoshutka please also bump patch version to 0.10.1 here:

cozystack/packages/apps/postgres/Chart.yaml

Line 19 in 1d2ccbd

version: 0.10.0

and run make gen-versions-map from /packages/apps to update the version

make gen-versions-map i cant do it with my macOS i think...

@etoshutka etoshutka force-pushed the double-template branch 2 times, most recently from 63460e7 to a2fdfcf Compare April 24, 2025 09:26
@etoshutka @kvaps
[postgres] remove douplicated template from backup manifest
19409d8 
Signed-off-by: Ian Simon <cheatmaster114@gmail.com>
@kvaps kvaps force-pushed the double-template branch from a2fdfcf to 19409d8 Compare April 24, 2025 09:30
@kvaps
Copy link
Member
kvaps commented Apr 24, 2025

@etoshutka Okay, we probably need to update our tooling.
I fixed commit and version_map, thank you!

kvaps
kvaps approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member
@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps kvaps changed the title double template [postgres] remove douplicated template from backup manifest Apr 24, 2025
@kvaps kvaps merged commit 3f47181 into cozystack:main Apr 24, 2025
6 checks passed
@github-actions GitHub Actions
Copy link

Successfully created backport PR for release-0.30:

@github-actions github-actions bot mentioned this pull request Apr 24, 2025
Merged
kvaps added a commit that referenced this pull request Apr 24, 2025
@kvaps
[Backport release-0.30] [postgres] remove douplicated template from b…
d70cdfd 
…ackup manifest (#874)

# Description
Backport of #872 to `release-0.30`.
@NickVolynkin NickVolynkin mentioned this pull request Apr 24, 2025
Open
@NickVolynkin
Copy link
Collaborator

@etoshutka thank you! This change was released in https://github.com/cozystack/cozystack/releases/tag/v0.31.0-rc.1 and https://github.com/cozystack/cozystack/releases/tag/v0.30.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickVolynkin NickVolynkin NickVolynkin left review comments

@kvaps kvaps kvaps approved these changes

@lllamnyp lllamnyp Awaiting requested review from lllamnyp lllamnyp is a code owner

@klinch0 klinch0 Awaiting requested review from klinch0 klinch0 is a code owner

Assignees
No one assigned
Labels
backport Should change be backported on previus release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double template in postgres backup
3 participants
@etoshutka @kvaps @NickVolynkin
0