8000 Make kubevirt's CPU allocation ratio configurable by lllamnyp · Pull Request #905 · cozystack/cozystack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make kubevirt's CPU allocation ratio configurable #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Make kubevirt's CPU allocation ratio configurable #905

merged 1 commit into from
Apr 30, 2025

Conversation

lllamnyp
Copy link
Member
@lllamnyp lllamnyp commented Apr 29, 2025 •
edited by coderabbitai bot
Loading

Kubevirt's default cpu-to-vcpu ration is 1:10, which might be a bit extreme for some users. This patch introduces a new key in the Cozystack configmap, "cpu-allocation-ratio" where admins of Cozystack can specify an alternative value, if needed.

Summary by CodeRabbit

  • New Features
    • Added support for optionally configuring a CPU allocation ratio for KubeVirt deployments when the relevant setting is provided.
  • Chores
    • Improved configuration flexibility for KubeVirt by allowing dynamic injection of CPU allocation settings.

@lllamnyp
Make kubevirt's CPU allocation ratio configurable
6106a9f 
Kubevirt's default cpu-to-vcpu ration is 1:10, which might be a bit
extreme for some users. This patch introduces a new key in the Cozystack
configmap, "cpu-allocation-ratio" where admins of Cozystack can specify
an alternative value, if needed.

Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp lllamnyp requested review from kvaps and klinch0 as code owners April 29, 2025 13:16
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 29, 2025 •
edited
Loading

Walkthrough

A conditional mechanism was introduced to propagate a cpuAllocationRatio value from a configuration source into the KubeVirt Helm release and its custom resource manifest. The system now checks for a cpu-allocation-ratio key in the cozystack ConfigMap and, if present, includes this value in both the Helm chart values and the KubeVirt CR's developerConfiguration. No changes were made to exported or public entity declarations, and the update is limited to YAML configuration and templating logic.

Changes

File(s) Change Summary
packages/core/platform/bundles/paas-full.yaml Added a conditional block to inject cpuAllocationRatio from cozystack ConfigMap into the Helm release values for KubeVirt.
packages/system/kubevirt/templates/kubevirt-cr.yaml Updated the KubeVirt CR template to conditionally include the cpuAllocationRatio field if the value is set.

Sequence Diagram(s)

sequenceDiagram
    participant ConfigMap (cozystack)
    participant Helm Release (kubevirt)
    participant KubeVirt CR

    ConfigMap-->>Helm Release: Provide cpu-allocation-ratio (if exists)
    Helm Release-->>KubeVirt CR: Inject cpuAllocationRatio into developerConfiguration (if set)
Loading

Poem

In YAML fields where configs grow,
A ratio for CPUs now may show.
If cozystack whispers the magic key,
KubeVirt will set it, as quick as can be.
Rabbits hop, templates bloom,
Conditional logic finds its room! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 108fc64 and 6106a9f.

📒 Files selected for processing (2)
  • packages/core/platform/bundles/paas-full.yaml (1 hunks)
  • packages/system/kubevirt/templates/kubevirt-cr.yaml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
packages/system/kubevirt/templates/kubevirt-cr.yaml

[warning] 14-14: wrong indentation: expected 4 but found 6

(indentation)

[error] 13-13: syntax error: expected the node content, but found '-'

(syntax)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test
🔇 Additional comments (2)
packages/core/platform/bundles/paas-full.yaml (1)

137-141: Simplify and ensure valid YAML indentation for the cpuAllocationRatio block
The new block correctly reads cpu-allocation-ratio from the ConfigMap and conditionally injects it into values. To reduce boilerplate and avoid potential indentation pitfalls, you can use a with directive and eliminate the temporary variable. For example:

-  {{- $cpuAllocationRatio := index $cozyConfig.data "cpu-allocation-ratio" }}
-  {{- if $cpuAllocationRatio }}
-  values:
-    cpuAllocationRatio: {{ $cpuAllocationRatio }}
-  {{- end }}
+  {{- with index $cozyConfig.data "cpu-allocation-ratio" }}
+  values:
+    cpuAllocationRatio: {{ . }}
+  {{- end }}

This also shrinks the code and aligns the block under the existing release fields.
[ suggest_optional_refactor ] [ request_verification ]

To verify correct rendering and indentation, run:

yamllint -d "{extends: default}" packages/core/platform/bundles/paas-full.yaml
helm template cozystack packages/core/platform/bundles/paas-full.yaml
packages/system/kubevirt/templates/kubevirt-cr.yaml (1)

13-15: Approve conditional injection of cpuAllocationRatio
The Helm template correctly includes the cpuAllocationRatio field under developerConfiguration only when .Values.cpuAllocationRatio is set. This aligns with chart best practices and matches your changes in the bundle.
Ignore the YAMLLint warnings here—they’re false positives caused by Helm templating directives.
[ approve_code_changes ] [ skip ]

🧰 Tools
🪛 YAMLlint (1.35.1)

[warning] 14-14: wrong indentation: expected 4 but found 6

(indentation)

[error] 13-13: syntax error: expected the node content, but found '-'

(syntax)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kvaps
kvaps approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member
@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lllamnyp lllamnyp merged commit c482289 into main Apr 30, 2025
6 checks passed
@lllamnyp lllamnyp deleted the feat/configurable-cpu-allocation-ratio branch April 30, 2025 06:53
lllamnyp added a commit that referenced this pull request May 20, 2025
@lllamnyp
Make kubevirt's CPU allocation ratio configurable (#905)
627d9f1 
Kubevirt's default cpu-to-vcpu ration is 1:10, which might be a bit
extreme for some users. This patch introduces a new key in the Cozystack
configmap, "cpu-allocation-ratio" where admins of Cozystack can specify
an alternative value, if needed.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added support for optionally configuring a CPU allocation ratio for
KubeVirt deployments when the relevant setting is provided.
- **Chores**
- Improved configuration flexibility for KubeVirt by allowing dynamic
injection of CPU allocation settings.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit c482289)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp lllamnyp mentioned this pull request May 20, 2025
Closed
This was referenced May 28, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvaps kvaps kvaps approved these changes

@klinch0 klinch0 klinch0 approved these changes

Assignees

@kvaps kvaps

@klinch0 klinch0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lllamnyp @kvaps @klinch0
0