[e2e] Return genisoimage to the e2e-test Dockerfile #962
Conversation
WalkthroughThe Dockerfile for the testing sandbox was updated to install the Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/testing/images/e2e-sandbox/Dockerfile (1)
11-11: Restoredgenisoimageis correct; consider combining and cleaning apt steps to slim the imageReinstating
genisoimagehere restores ISO creation support as intended. To reduce layers and shrink the final image, you could merge the update/install steps, useapt-get, and remove cached lists. For example:-RUN apt update -q -RUN apt install -yq --no-install-recommends genisoimage ca-certificates qemu-kvm qemu-utils iproute2 iptables wget xz-utils netcat curl jq make git +RUN apt-get update -qq \ + && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ + genisoimage ca-certificates qemu-kvm qemu-utils iproute2 iptables wget xz-utils netcat curl jq make git \ + && rm -rf /var/lib/apt/lists/*
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
packages/core/testing/images/e2e-sandbox/Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Test
…le which leds to test fail due to the fact that genisoimage is missing and runner enable to create image. issue reference - https://github.com/cozystack/cozystack/actions/runs/15084476654/job/42406141954. restored genisoimage package installation in Dockerfile Signed-off-by: Ahmad Murzahmatov <gwynbleidd2106@yandex.com>
645d8ab to
9698f3c
Compare
Formatting issues in the commit message aren't worth the git commit --amend && git push --force and a full re-run of all the tests for a badly needed bugfix which is blocking everyone elses pipeline right now.
commit 7a7512d removed genisoimage package installation from Dockerfile which leds to test fail due to the fact that genisoimage is missing and runner enable to create image. [issue reference](https://github.com/cozystack/cozystack/actions/runs/15084476654/job/42406141954). restored genisoimage package installation in Dockerfile. (cherry 9744 picked from commit 8d74a35) Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
commit 7a7512d removed genisoimage package installation from Dockerfile which leds to test fail due to the fact that genisoimage is missing and runner enable to create image. issue reference.
restored genisoimage package installation in Dockerfile
Summary by CodeRabbit