-
Notifications
You must be signed in to change notification settings - Fork 100
[ci] Support alpha and beta pre-releases #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
WalkthroughThe workflows for pull request releases and tag-based releases were updated to recognize and validate prerelease tags with "alpha", "beta", or "rc" suffixes followed by a dot and a number (e.g., Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Workflow Validator
Developer->>GitHub Actions: Push tag (e.g., v1.2.3-alpha.1)
GitHub Actions->>Workflow Validator: Validate tag format
alt Tag matches v*.*.*(-alpha.N|-beta.N|-rc.N)
Workflow Validator->>GitHub Actions: Proceed with workflow
else Invalid tag format
Workflow Validator->>GitHub Actions: Fail with updated error message
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/tags.yaml (1)
54-59
: Extend prerelease parsing regex
The new regex/^v(\d+\.\d+\.\d+)(-(?:alpha|beta|rc)\.\d+)?$/
and error message now enforce proper-alpha.N
,-beta.N
, or-rc.N
suffixes. Version concatenation withm[2] ?? ''
is spot-on.For clarity, consider renaming the flag variable from
isRc
toisPrerelease
, since it now applies to all prerelease types:- const isRc = Boolean(m[2]); + const isPrerelease = Boolean(m[2]);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/pull-requests-release.yaml
(1 hunks).github/workflows/tags.yaml
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Test
🔇 Additional comments (4)
.github/workflows/pull-requests-release.yaml (1)
140-145
: Extend prerelease tag validation to include alpha and beta
The updated regex/^v(\d+\.\d+\.\d+)(-(?:alpha|beta|rc)\.\d+)?$/
correctly matches-alpha.N
,-beta.N
, and-rc.N
suffixes. The accompanying error message and version extraction (m[2] ?? ''
) handle absence or presence of a suffix gracefully..github/workflows/tags.yaml (3)
6-9
: Add alpha and beta tag triggers
The workflow now listens forv*.*.*-beta.*
andv*.*.*-alpha.*
pushes alongside stable (v*.*.*
) and RC (v*.*.*-rc.*
) tags, ensuring prereleases kick off the prepare-release job.
172-172
: This log message change is purely cosmetic; it doesn’t affect functionality.
185-185
: Only a comment tweak here—no action needed.
Signed-off-by: Andrei Kvapil kvapss@gmail.com
Summary by CodeRabbit
-alpha.1
,-beta.2
) in addition to "rc".