free electron additions #9
Conversation
…eader stores this information as a secondary species. moose_testdb.json has free electron in it to enable testing
|
Sorry that we didn't see this before, @cpgr. But i guess the PR still hasn't been reviewed so it doesn't matter too much.... |
|
Oh my goodness, this free electron is a nightmare. I just realised its "basis species" aren't actually basis species since they include O2(g). For this set of work that's not a problem, BUT, in order to include "e-" in the list of secondary species in real models, we have to either:
|
|
Sorry I didn't see this earlier - I had an afternoon off! I don't really like the idea of having to manually change entries after converting. It would be so easy to muck something up or forget. Is this only used to calculated pe or eh or whatever it is called? Can we make sure that O2(g) is added as a secondary species when we add e-, and that O2(aq) is added as a basis species, to allow the reactions to be calculated? Or am I looking at this wrong? I don't really know! |
|
When figuring out which secondary species to add, you look at their reactions and add all secondaries whose reaction contains only the basis species specified by the user. (There are complications from redox, but that doesn't matter here). I wouldn't be surprised if GWB does something like you suggest, but it's ugly in my opinion. Eg, whenever you add O2(aq) as basis species, O2(g) and e- are automatically added too. What if another database has e- defined in terms of basis species? But whatever we decide, it doesn't impact this PR, only the stuff that i'm currently doing in another branch. |
free electron added to python convert utilities. GeochemicalDatabaseReader stores this information as a secondary species. moose_testdb.json has free electron in it to enable testing
Complete each of the following items before creating a PR