10000 add package tcmalloc by craffael · Pull Request #493 · cpp-pm/hunter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add package tcmalloc #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

add package tcmalloc #493

wants to merge 6 commits into from

Conversation

craffael
Copy link
  • I've followed this guide
    step by step carefully. Yes

Note that currently all ci-jobs fail because the tcmalloc needs cmake 3.21 or higher. Maybe it would be an option to bump cmake version in polly's install-ci-dependencies.py...?

@rbsheth rbsheth mentioned this pull request Dec 7, 2021
Merged
@rbsheth
Copy link
Member
rbsheth commented Dec 16, 2021

@craffael I don't know what we should do to test this package. Thoughts?

@rbsheth
Copy link
Member
rbsheth commented Dec 16, 2021

(without bumping the CMake version in CI, necessarily)

@craffael
Copy link
Author

Sorry for taking such a long time. Regarding the problem with the CMake version, I think the optimal solution would be if individual packages can specify another cmake version to use for ci. But this would require a few changes on the polly repository and the one over here. If you want I can make PR's?

@craffael
Copy link
Author

Alternatively you could also just let the ci fail for tcmalloc... I guess there are not so many packages which require such a recent version of cmake...

@rbsheth
Copy link
Member
rbsheth commented Feb 3, 2022

Sorry for taking such a long time. Regarding the problem with the CMake version, I think the optimal solution would be if individual packages can specify another cmake version to use for ci. But this would require a few changes on the polly repository and the one over here. If you want I can make PR's?

No problem, I've been pretty slow these days too... Sure, let's do that and I can review.

@NeroBurner
Copy link

any updates on this?

NeroBurner
NeroBurner reviewed Jun 2, 2025
View reviewed changes
Copy link
@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating PR to require CMake 3.10

@NeroBurner NeroBurner added the package:new New package label Jun 2, 2025
@NeroBurner
Copy link

all CI checks fail. In GCC-13 there is an ABSL bug.

[ 50%] Building CXX object tcmalloc/CMakeFiles/common_256k_pages_obj.dir/span.cc.o
/home/runner/work/hunter/hunter/_Base/xxxxxxx/cbf46ff/0867b2f/Build/tcmalloc/Source/tcmalloc/span.cc: In static member function ‘static uint16_t tcmalloc::tcmalloc_internal::Span::CalcReciprocal(size_t)’:
/home/runner/work/hunter/hunter/_Base/xxxxxxx/cbf46ff/0867b2f/Build/tcmalloc/Source/tcmalloc/span.cc:233:3: error: ‘ABSL_INTERNAL_ASSUME’ was not declared in this scope; did you mean ‘ABSL_INTERNAL_LOG’?
  233 |   ABSL_INTERNAL_ASSUME(size <= kMaxSize);
      |   ^~~~~~~~~~~~~~~~~~~~
      |   ABSL_INTERNAL_LOG
/home/runner/work/hunter/hunter/_Base/xxxxxxx/cbf46ff/0867b2f/Build/tcmalloc/Source/tcmalloc/span.cc: In static member function ‘static uint16_t tcmalloc::tcmalloc_internal::Span::CalcReciprocal(size_t)’:
/home/runner/work/hunter/hunter/_Base/xxxxxxx/cbf46ff/0867b2f/Build/tcmalloc/Source/tcmalloc/span.cc:233:3: error: ‘ABSL_INTERNAL_ASSUME’ was not declared in this scope; did you mean ‘ABSL_INTERNAL_LOG’?
  233 |   ABSL_INTERNAL_ASSUME(size <= kMaxSize);
      |   ^~~~~~~~~~~~~~~~~~~~
      |   ABSL_INTERNAL_LOG

Closing PR, please reopen if you're still around and want to work on this again. Sorry for the long wait

@NeroBurner NeroBurner closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeroBurner NeroBurner NeroBurner left review comments

Assignees
No one assigned
Labels
package:new New package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craffael @rbsheth @NeroBurner
0