Update 'SDL2' package to v2.0.18 #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeroBurner
reviewed
Dec 17, 2021
<
8000
div data-view-component="true" class="TimelineItem-body my-0">
| VERSION | ||
| "2.0.18" | ||
| URL | ||
| "https://github.com/libsdl-org/SDL/archive/release-2.0.18.tar.gz" |
There was a problem hiding this comment.
SDL can now be used directly from upstream? I doubt SDL has no external dependencies for building. Or did they themself add Hunter support?
There was a problem hiding this comment.
Yes. It has no external dependencies. 2.0.12 only needed an alias for static lib (SDL2::SDL2 to SDL2::SDL2-static, for hunter backward compatibility), same as 2.0.16 (2.0.14 cmake was broken a lot, so I didn't bother). They finally put the exact same alias in SDL2Config.cmake in 2.0.18, so at least this version can be used from upstream.
NeroBurner
approved these changes
Dec 17, 2021
rbsheth
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step by step carefully. [Yes]
From official repo.