Bumps range_v3 to latest version. #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really have no clue why some windows checks are failing, and have no access to windows os. |
This package requires >=vs 2019.
|
Apparently this package requires visual c++ >=2019 on windows. I disabled the older versions in the build matrix json and now all tests passed. |
rbsheth
reviewed
Nov 30, 2020
| @@ -0,0 +1,18 @@ | |||
| [ | |||
There was a problem hiding this comment.
You can keep the toolchains failing and remove this file.
Per reviewer comments.
rbsheth
approved these changes
Dec 4, 2020
tstack
pushed a commit
to tstack/hunter
that referenced
this pull request
Jan 28, 2021
* Bumps range_v3 to latest version. * Disables support for old windows compilers This package requires >=vs 2019. * Delete matrix.json Per reviewer comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step by step carefully. [Yes
step by step carefully. [Yes]