8000 crash fixes by cranci1 · Pull Request #28 · cranci1/Sora · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

crash fixes #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

crash fixes #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Sora/Utils/MediaPlayer/VideoPlayer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,19 @@ class VideoPlayerViewController: UIViewController {
let playerItem = AVPlayerItem(asset: asset)

player = AVPlayer(playerItem: playerItem)

playerViewController = NormalPlayer()
playerViewController?.player = player
addPeriodicTimeObserver(fullURL: fullUrl)

if let playerViewController = playerViewController {
playerViewController.view.frame = self.view.frame
self.view.addSubview(playerViewController.view)
self.addChild(playerViewController)
addChild(playerViewController)
playerViewController.view.frame = view.bounds
playerViewController.view.autoresizingMask = [.flexibleWidth, .flexibleHeight]
view.addSubview(playerViewController.view)
playerViewController.didMove(toParent: self)
}

addPeriodicTimeObserver(fullURL: fullUrl)
let lastPlayedTime = UserDefaults.standard.double(forKey: "lastPlayedTime_\(fullUrl)")
if lastPlayedTime > 0 {
let seekTime = CMTime(seconds: lastPlayedTime, preferredTimescale: 1)
Expand Down
2 changes: 1 addition & 1 deletion Sora/Views/MediaInfoView/MediaInfoView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ struct MediaInfoView: View {
}

private func openSafariViewController(with urlString: String) {
guard let url = URL(string: urlString) else {
guard let url = URL(string: urlString), UIApplication.shared.canOpenURL(url) else {
Logger.shared.log("Unable to open the webpage", type: "Error")
return
}
Expand Down
2 changes: 1 addition & 1 deletion Sulfur.xcodeproj/project.xcworkspace/contents.xcworkspacedata
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
0