8000 huge things by cranci1 · Pull Request #50 · cranci1/Sora · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

huge things #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Mar 19, 2025
Merged

huge things #50

merged 32 commits into from
Mar 19, 2025

Conversation

cranci1
Copy link
Owner
@cranci1 cranci1 commented Mar 19, 2025

No description provided.

xibrox and others added 30 commits March 15, 2025 08:16
fixed "Mark all previous" counting in the logger and removing a series from bookmarks when you open them from the home tab it no longer kicks you out
this bs took way too much time logic later 🙏
request.addValue("\(module.metadata.baseUrl)", forHTTPHeaderField: "Referer")
request.addValue("Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36", forHTTPHeaderField: "User-Agent")

URLSession.shared.dataTask(with: request) { [weak self] data, response, error in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused parameter in a closure should be replaced with _

Suggested change
URLSession.shared.dataTask(with: request) { [weak self] data, response, error in
URLSession.shared.dataTask(with: request) { [weak self] data, _, _ in

if UserDefaults.standard.object(forKey: "fetchEpisodeMetadata") == nil
|| UserDefaults.standard.bool(forKey: "fetchEpisodeMetadata") {
fetchEpisodeDetails()
}
currentProgress = progress
}
.onChange(of: progress) { newProgress in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused parameter in a closure should be replaced with _

Suggested change
.onChange(of: progress) { newProgress in
.onChange(of: progress) { _ in

@cranci1 cranci1 merged commit 77797d9 into main Mar 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5E2F
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0