CI: Maintenance for DynamoDB/LocalStack integration testing and more #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
The changes update the CI workflow and internal test configuration for LocalStack and Python versions. The GitHub Actions matrix now tests against Python 3.13 instead of 3.11 (and removes 3.8), removes a yarl dependency comment, and uses LocalStack 4.5 instead of 3.6. The default LocalStack version in the test container class is updated to 4.5 with minor docstring clarifications. Additionally, some setuptools installation commands were simplified or removed in the main workflow.
## Changes
| File(s) | Change Summary |
|-------------------------------------------------------|--------------------------------------------------------------------------------------------------|
| .github/workflows/dynamodb.yml, .github/workflows/influxdb.yml, .github/workflows/mongodb.yml, .github/workflows/main.yml | Updated CI Python versions: removed 3.8 and 3.11, replaced 3.12 with 3.13; removed yarl comment; simplified setuptools install commands; reformatted Python version lists. |
| cratedb_toolkit/testing/testcontainers/localstack.py | Changed default LocalStack version from 3.7 to 4.5; clarified docstrings for environment variables. |
## Poem
> A hop and a skip, we leap ahead,
> With Python new and LocalStack led.
> The tests now run with versions bright,
> Chasing bugs in the CI night.
> Containers kept, our code in tune—
> The toolkit hums a modern tune! 🐇✨📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (29)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
hammerhead
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This patch just includes maintenance items in form of version updates and friends, nothing too significant.
References
Provide the best of what LocalStack can offer in preparation for adding integration tests to another patch around DMS over Kinesis.