8000 Use NumberInput for Configuration · Issue #10 · crc-org/crc-react-components · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Use NumberInput for Configuration #10

Closed
2 tasks
gbraad opened this issue Jan 10, 2022 · 2 comments
Closed
2 tasks

Use NumberInput for Configuration #10

gbraad opened this issue Jan 10, 2022 · 2 comments
Assignees
@gbraad

Comments

@gbraad
Copy link
Collaborator
gbraad commented Jan 10, 2022 •
edited
Loading
  • CSS is not properly applied to the plus/minus buttons Storybook issue
  • Numbers aren't clamped

Attachments

image

https://github.com/code-ready/crc-react-components/blob/675f07b7487ab18fbea67028c8c4127545629225/src/components/Settings.jsx#L69
@gbraad gbraad self-assigned this Jan 11, 2022
@gbraad gbraad mentioned this issue Jan 12, 2022
Open
@gbraad

This comment has been minimized.

Sign in to view
@gbraad
Copy link
Collaborator Author
gbraad commented Jan 12, 2022

image

@gbraad gbraad moved this to In Progress in Project planning Jan 18, 2022
@gbraad gbraad changed the title Remaining issues with the NumberInput for Configuration Use NumberInput for Configuration Jan 19, 2022
gbraad added a commit to gbraad-redhat/crc-react-components that referenced this issue Jan 19, 2022
@gbraad
Fixes crc-org#10 use NumberInput for configuration
06b5f15
gbraad added a commit to gbraad-redhat/crc-react-components that referenced this issue Jan 19, 2022
@gbraad
Fixes crc-org#10 use NumberInput for configuration
03ef50f
@gbraad gbraad closed this as completed in eb3c6d7 Jan 19, 2022
Repository owner moved this from In Progress to Done in Project planning Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gbraad gbraad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbraad
0