8000 Corrected Dublin Core Terms namespace by Bobulous · Pull Request #135 · creativecommons/chooser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Corrected Dublin Core Terms namespace #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2020
Merged

Corrected Dublin Core Terms namespace #135

merged 1 commit into from
Mar 28, 2020

Conversation

Bobulous
Copy link
Contributor

Modified namespace prefix from "dc" to "dct" within the span element for the title, to match the xmlns:dct declaration for the Dublin Core Terms namespace.

Description

Unless I'm misunderstanding the intent of the code, the span element for the title is trying to refer to the Dublin Core Terms "title" property, in which case I believe it should be referring to the "dct" namespace prefix declared within one of its ancestor elements.

Other information

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Bobulous
Corrected Dublin Core Terms namespace
aa140ce 
Modified namespace prefix from "dc" to "dct" within the span element for the title, to match the xmlns:dct declaration for the Dublin Core Terms namespace.
@Bobulous Bobulous requested review from a team March 13, 2020 15:58
@akmadian
Copy link
Member

I'm going to close this PR, please include these changes in #134

@akmadian akmadian closed this Mar 13, 2020
@akmadian akmadian reopened this Mar 13, 2020
@akmadian
Copy link
Member

My apologies, I didn't see your comment about editing multiple files per patch in your other PR :) The changes look good to me, i'll wait on Olga's approval on your other PR to merge this one

@Bobulous
Copy link
Contributor Author

Yeah, I did try to get both changes into a single pull request, but couldn't find a way to do it. If someone knows the secret, let me know.

@obulat
Copy link
Contributor
obulat commented Mar 28, 2020

@Bobulous , thank you for your PR! To be honest, I am not very familiar with the markup. I used the markup from this document to write the metadata with dc: for title, but a more detailed guide on ccREL does use dct: for title. I am merging the PRs, thank you for your contribution!

obulat
obulat approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor
@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing dc: to dct: in ccREL markup.

@obulat obulat merged commit 5a1cede into creativecommons:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obulat obulat obulat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bobulous @akmadian @obulat
0