8000 Add unit tests for the Step component by akmadian · Pull Request #187 · creativecommons/chooser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add unit tests for the Step component #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2020
Merged

Add unit tests for the Step component #187

merged 3 commits into from
Oct 7, 2020

Conversation

akmadian
Copy link
Member
@akmadian akmadian commented Oct 6, 2020

Fixes

Fixes #123 by @akmadian

Description

This PR adds unit tests for the Step component.

Technical details

  • This PR does not test every possible permutation of props because simply testing the logic in this particular component should cover almost all cases assuming the locale file has the proper schema.
  • This PR does not include e2e tests because just about all permutations of step functionality are covered in the Stepper component's e2e tests.

Tests

Run npm run test

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@akmadian akmadian requested a review from a team as a code owner October 6, 2020 08:23
@akmadian akmadian requested review from obulat and removed request for a team October 6, 2020 08:23
obulat
obulat approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor
@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I've added some snapshot testing for permutation of props, because the layout of the component changes accordingly.
Also, I've finally found the best way of testing with i18n in chooser: by mocking it and returning the key itself, so that the key is used as the text for html.
I hope it's ok with you, @akmadian .

tests/unit/specs/components/Step.spec.js

config.mocks.i18n = i18n

config.mocks.$t = key => key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we return key, it is added to html as is (eg. stepper.SA.not-selected), which is enough for testing.

@akmadian
Copy link
Member Author
akmadian commented Oct 7, 2020

Yes that looks great! Thanks for catching and fixing those things : ) I'll merge

@akmadian akmadian merged commit da4ff09 into master Oct 7, 2020
@obulat obulat deleted the tests/step branch December 4, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obulat obulat obulat approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit and e2e tests for the Step component
2 participants
@akmadian @obulat
0