8000 Adjusted positioning of the 'Confused Need Help' and 'Recommended License' sections in mobile view by soustab10 · Pull Request #459 · creativecommons/chooser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjusted positioning of the 'Confused Need Help' and 'Recommended License' sections in mobile view #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

Adjusted positioning of the 'Confused Need Help' and 'Recommended License' sections in mobile view #459

merged 3 commits into from
Mar 10, 2023

Conversation

soustab10
Copy link
Contributor

Fixes

Fixes #455 by @soustab10

Description

Fixes the position of 'Confused Need Help' and 'Recommended License' sections in mobile view for better ease of the user.

Screenshots

image
image

Device used for reference: Samsung Galaxy S20 Ultra

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, includi
8000
ng my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@soustab10 soustab10 requested review from a team as code owners March 10, 2023 06:59
@soustab10 soustab10 requested review from TimidRobot, possumbilities and obulat and removed request for a team March 10, 2023 06:59
Shafiya-Heena
Shafiya-Heena approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member
@Shafiya-Heena Shafiya-Heena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soustab10 Thank you for the contribution.

@possumbilities
Copy link
Contributor

Hi @soustab10 can you update your branch here with the latest version of main to see if the tests pass now? I merged in another PR that should fix the failing tests here, but it'll need the newest commits first.

@soustab10
Copy link
Contributor Author

Hi @soustab10 can you update your branch here with the latest version of main to see if the tests pass now? I merged in another PR that should fix the failing tests here, but it'll need the newest commits first.

Sure. Thank you.

@soustab10
Copy link
Contributor Author

@possumbilities Thank you, build test has passed.

@possumbilities possumbilities merged commit 4e20e04 into creativecommons:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cronus1007 Cronus1007 Cronus1007 approved these changes

@Shafiya-Heena Shafiya-Heena Shafiya-Heena approved these changes

@TimidRobot TimidRobot Awaiting requested review from TimidRobot TimidRobot is a code owner automatically assigned from creativecommons/technology

@possumbilities possumbilities Awaiting requested review from possumbilities possumbilities is a code owner automatically assigned from creativecommons/technology

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from creativecommons/ct-license-chooser-maintainers

Assignees

@soustab10 soustab10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Adjust positioning of the 'Confused Need Help' and 'Recommended License' sections in mobile view
4 participants
@soustab10 @possumbilities @Cronus1007 @Shafiya-Heena
0