8000 correct `h1` to "Chooser", build out semantic html for "results" area by possumbilities · Pull Request #557 · creativecommons/chooser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

correct h1 to "Chooser", build out semantic html for "results" area #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 10, 2025
Merged

correct h1 to "Chooser", build out semantic html for "results" area #557

merged 8 commits into from
Jan 10, 2025

Conversation

possumbilities
Copy link
Contributor
@possumbilities possumbilities commented Jan 9, 2025 •
edited
Loading

Description

  • defines a basic semantic markup "component" for license recommendation, and a general license sub-component within, with appropriate sub-elements.
  • creates a localized implementation of the cc license icons for use with the icon-attach helper class with the relevant cc-icons.svg sprite sheet.
  • corrects the page title
  • corrects the path for the page-level cc license icons (they now load instead of 404)
  • zeros out the <template> for now to be used later with JS

Technical details

Things remain messy and unfinished, but we now have a basic area within which to populate a relevant license recommendation when JS functionality is added later.

I tried to keep the semantics simple, but I think it might get improvements later. It made sense that the conditions definitions broken down within the various licenses was best served as a definition list, rather than just a regular ol. We are, just a tad bit being mushy with semantics since there's certainly an argument around "one item does not a list make", but I think it's close enough in spirit to be fine when there's only one item, to gain the added semantics when it is not.

Next up will be the "How to mark your work for attribution" area markup.

Screenshots

license-rec-area

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@possumbilities possumbilities self-assigned this Jan 9, 2025
@possumbilities possumbilities marked this pull request as ready for review January 10, 2025 18:28
@possumbilities possumbilities requested review from a team as code owners January 10, 2025 18:28
@possumbilities possumbilities requested review from kgodey and removed request for a team and kgodey January 10, 2025 18:28
TimidRobot
TimidRobot approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member
@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@possumbilities possumbilities merged commit ec6cde2 into refactor Jan 10, 2025
@possumbilities possumbilities deleted the semantic-results branch January 10, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimidRobot TimidRobot TimidRobot approved these changes

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena

Assignees

@possumbilities possumbilities

Labels
None yet
Projects
possumbilities
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@possumbilities @TimidRobot
0