8000 alter namespaces, restructure code, amend plaint text markup to pull from `<template>` instead of raw JS by possumbilities · Pull Request #564 · creativecommons/chooser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

alter namespaces, restructure code, amend plaint text markup to pull from <template> instead of raw JS #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 10, 2025
Merged

alter namespaces, restructure code, amend plaint text markup to pull from <template> instead of raw JS #564

merged 11 commits into from
Feb 10, 2025

Conversation

possumbilities
Copy link
Contributor
@possumbilities possumbilities commented Jan 21, 2025 •
edited
Loading

Description

  • uses Legal Tools namespaces where appropriate for better naming across JS, CSS, and HTML
  • changes the use of license to tool in most non-user facing situations. If naming is tied to copy, then it has remained the same (for example the question "Do you know which license you need?" is tied to the semantics of the state path and the HTML (which influences the naming conventions in the HTML, CSS, and JS). Until copy changes occur these naming use-cases must remain.
  • moves markup templating for the plaint text into HTML as much as possible (later on I may find I have to reverse this if the other formats don't play well with <template> fragments and token replacement

Technical details

Wherever reasonable naming has been updated to better match the CC Legal Tools. This is not 1:1 since there are several contexts in which there isn't a direct 1:1 relationship, and others where existing copy demands another labelling (usually license over tool). Additionally, there are some minor restructuring of the format rendering code, and an attempt to move as much of the markup back into the HTML as possible.

Next steps will involve building out the tabbed interface in a semantic and Accessible way, with some nice mobile fallbacks, and then likely the first bits of visual UX "skinning" to start dressing up the UI more.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@possumbilities possumbilities self-assigned this Jan 21, 2025
@possumbilities possumbilities changed the title alter namespaces, restructure code alter namespaces, restructure code, added tabbed UX Feb 3, 2025
@possumbilities possumbilities changed the title alter namespaces, restructure code, added tabbed UX alter namespaces, restructure code Feb 4, 2025
@possumbilities possumbilities marked this pull request as ready for review February 10, 2025 15:30
@possumbilities possumbilities requested review from a team as code owners February 10, 2025 15:30
@possumbilities possumbilities requested review from kgodey and removed request for a team February 10, 2025 15:30
@possumbilities possumbilities changed the title alter namespaces, restructure code alter namespaces, restructure code, amend plaint text markup to pull from <template> instead of raw JS Feb 10, 2025
@possumbilities possumbilities removed request for a team and kgodey February 10, 2025 15:31
@possumbilities possumbilities merged commit b434890 into refactor Feb 10, 2025
@possumbilities possumbilities deleted the structure-namespaces branch February 10, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shafiya-Heena Shafiya-Heena Shafiya-Heena approved these changes

@TimidRobot TimidRobot Awaiting requested review from TimidRobot

Assignees

@possumbilities possumbilities

Labels
None yet
Projects
possumbilities
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@possumbilities @Shafiya-Heena
0