8000 Fix schema and credential definition pages UI related issues by sujitaw · Pull Request #1005 · credebl/studio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix schema and credential definition pages UI related issues #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally 8000 send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 29, 2025
Merged

Fix schema and credential definition pages UI related issues #1005

merged 10 commits into from
May 29, 2025

Conversation

sujitaw
Copy link
@sujitaw sujitaw commented May 28, 2025 •
edited
Loading

What

Fixes

  • Dropdown list for data selection in create schema
  • Create schema” button not visible in light mode but displays in dark mode on schemas page
  • On the Create Schema page, the "Reset" and "Create" buttons are too close to the bottom edge of the card. Spacing needs to be added between the buttons and the bottom border of the card for better visual alignment.
  • The "+" icon on the "Create" button on the Create Credential Definition page is inconsistent with other icons. It appears in black, while all other button icons with text are displayed in white.
  • The button colors on hover in the "Create Credential Definition" page are not clearly visible because the background color is blue while the text color is black. This is inconsistent with other buttons across the CREDEBL platform, where all button text is white.
  • Notification message on credential Definition not as per standard.
  • fixing the delete button style on create schema to match the other buttons.

added message below credential
Screenshot from 2025-05-28 14-05-58
hovering over check on credential
Screenshot from 2025-05-28 14-03-41
Screenshot from 2025-05-28 12-35-08
added spacing around and the delete icon updated
image
the button theme for create button updated
image
Uploading image.png…

sujitaw added 3 commits May 27, 2025 20:04
@sujitaw
fix/ui related issues
4093fdb 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sujitaw
fix:ui related issues
81ff0ac 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sujitaw
fix/fixed ui related issues
19c6eaa 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sujitaw sujitaw requested a review from shitrerohit May 28, 2025 11:38
@sujitaw sujitaw self-assigned this May 28, 2025
sujitaw added 2 commits May 28, 2025 17:14
@sujitaw
fix/minor conditional correction for send button
e0fa67b 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sujitaw
fix/ attributes label css
3cacdec 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@RinkalBhojani
Copy link

@sujitaw - Last two screenshots are still showing black boarders.

sujitaw added 5 commits May 29, 2025 22:50
@sujitaw
fix / theme related changes
32a70eb 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sujitaw
Merge branch 'develop-nextjs' of https://github.com/credebl/studio in…
e964068 
…to fix/schema-and-credential-definition-pages-ui
@sujitaw
fix/removed comment
dca0681 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sujitaw
fix/ removed duplicates
f1010ce 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sujitaw
fix/renamed files and removed comments
532055d 
Signed-off-by: Sujit <sujit.sutar@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sujitaw sujitaw merged commit fac6394 into develop-nextjs May 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shitrerohit shitrerohit shitrerohit approved these changes

Assignees

@sujitaw sujitaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sujitaw @RinkalBhojani @shitrerohit
0