8000 fix: empty data fixed by MoulikaKulkarni · Pull Request #194 · credebl/studio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: empty data fixed #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 1, 2023
Merged

fix: empty data fixed #194

merged 5 commits into from
Sep 1, 2023

Conversation

MoulikaKulkarni
Copy link
Contributor

What

  • Empty data managed with the message
  • Truncated the Org DID
  • Renamed 'Agent and Wallet Spinup' as 'Create Wallet' and 'Setup Agent' button as 'Create'

@MoulikaKulkarni
fix: empty data fixed
8b3f821 
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
@MoulikaKulkarni MoulikaKulkarni self-assigned this Aug 31, 2023
ajile-in
ajile-in reviewed Aug 31, 2023
View reviewed changes
src/components/Issuance/IssuedCrdentials.tsx Outdated
<span className="block text-center p-4 m-8">There isn't any data available.</span>
</div>
)
// buttonContent={''}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented code.

ajile-in
ajile-in reviewed Aug 31, 2023
View reviewed changes
src/components/Verification/VerificationCredentialList.tsx Outdated
</div>
)

// buttonContent={''}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, please remove the commented code.

@MoulikaKulkarni
fix: removed comments
70ff9fa 
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
@ajile-in ajile-in self-requested a review August 31, 2023 13:04
ajile-in
ajile-in approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor
@ajile-in ajile-in left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

MoulikaKulkarni and others added 3 commits September 1, 2023 11:01
@MoulikaKulkarni
Merge branch 'main' into empty-messages-and-wallet-screen-change
dbfb0a0 
Signed-off-by: MoulikaKulkarni <143073666+MoulikaKulkarni@users.noreply.github.com>
@MoulikaKulkarni
fix: empty data
133da23 
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
@MoulikaKulkarni
Merge branch 'empty-messages-and-wallet-screen-change' of https://git…
2106ea4 
…hub.com/credebl/studio into empty-messages-and-wallet-screen-change
@tipusinghaw tipusinghaw merged commit 6b9d6d7 into main Sep 1, 2023
@tipusinghaw tipusinghaw deleted the empty-messages-and-wallet-screen-change branch September 1, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajile-in ajile-in ajile-in approved these changes

@tipusinghaw tipusinghaw tipusinghaw approved these changes

Assignees

@MoulikaKulkarni MoulikaKulkarni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoulikaKulkarni @ajile-in @tipusinghaw
0