-
Notifications
You must be signed in to change notification settings - Fork 9
Feat: endorsement list and request endorsement for schema #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e and flag, created custom function for ecosystem role check Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
… custom component Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…into ecosystem-endorsement-popups Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
feat: Ecosystem endorsement popups
…ed and updated sidebar code Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Kudos, SonarCloud Quality Gate passed!
|
isProcessing: boolean | ||
} | ||
|
||
const ConfirmModal = (props: IProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please be specific for the model name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a custom confirmation popup and we can use it anywhere in our code.
Can you please suggest a better name?
// const handleFilter = (e: React.ChangeEvent<HTMLSelectElement>) => { | ||
// console.log("Handle filter", e.target.value) | ||
// if (e.target.value === 'All schemas') { | ||
// setAllSchemaFlag(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code needed for other development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as we discussed, the Schema list does not require any filter for now as we are showing all the schemas created under ecosystems. So, for now, we can keep this code as it is. I'll remove this code in my next PR after discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the comments
What?