8000 fix: schema errors by 16-karan · Pull Request #504 · credebl/studio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: schema errors #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 29, 2023
Merged

fix: schema errors #504

merged 6 commits into from
Dec 29, 2023

Conversation

16-karan
Copy link
Contributor
@16-karan 16-karan commented Dec 28, 2023 •
edited
Loading

What

  • Handled button state on create schema
  • Handled pagination on the schema list
  • Handled loading condition
  • Handled empty message display

@16-karan 16-karan self-assigned this Dec 28, 2023
@16-karan 16-karan changed the title Fix schma errors fix: schema errors Dec 28, 2023
@16-karan
fix: schema list pagination
29b1c3b 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan
fix: loading and empty list mesaage display
74d8f8b 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan
fix: popup close timing
65baa97 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan
fix: loading condition
d8e4188 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sanjay-k1910
sanjay-k1910 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor
@sanjay-k1910 sanjay-k1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sanjay-k1910 sanjay-k1910 merged commit 1535e9f into develop Dec 29, 2023
@sanjay-k1910 sanjay-k1910 deleted the fix-schma-errors branch December 29, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjay-k1910 sanjay-k1910 sanjay-k1910 approved these changes

@nishad-ayanworks nishad-ayanworks Awaiting requested review from nishad-ayanworks

Assignees

@16-karan 16-karan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@16-karan @sanjay-k1910
0