8000 Fix: visibility eye icon on password field bug by bhavanakarwade · Pull Request #75 · credebl/studio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: visibility eye icon on password field bug #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2023
Merged

Fix: visibility eye icon on password field bug #75

merged 3 commits into from
Aug 3, 2023

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Resolved visibility eye icon on password field bug.

Why?

  • Eye icon is to allow the user to see the actual characters of the password they are typing, rather than showing them as bullets.

@bhavanakarwade
fix: missing visibility eye icon on password field bug
6fbe4c5 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'main' of https://github.com/credebl/studio into 190-vis…
05a177e 
…ibility-eye-icon-on-password-field
@bhavanakarwade bhavanakarwade added the bug Something isn't working label Aug 3, 2023
@bhavanakarwade bhavanakarwade self-assigned this Aug 3, 2023
@bhavanakarwade
remove: commented code
ee9ab3e 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
nishad-ayanworks
nishad-ayanworks approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor
@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nishad-ayanworks nishad-ayanworks merged commit 27c84cb into main Aug 3, 2023
@nishad-ayanworks nishad-ayanworks deleted the 190-visibility-eye-icon-on-password-field branch August 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

Assignees

@bhavanakarwade bhavanakarwade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavanakarwade @nishad-ayanworks
0