feat: Add W3C credentials verification #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
…C-Credentials-Verification
|
ankita-p17
approved these changes
Mar 4, 2024
sairanjit
reviewed
Mar 4, 2024
| @@ -489,11 +520,11 @@ export class VerificationService { | |||
| * @param payload | |||
| * @returns Get requested proof presentation details | |||
| */ | |||
| async _sendOutOfBandProofRequest(payload: IProofRequestPayload): Promise<{ | |||
| async _sendOutOfBandProofRequest(payload: IProofRequestPayload | IPresentationExchangeProofRequestPayload): Promise<{ | |||
There was a problem hiding this comment.
- In the subsequent PR change
IProofRequestPayloadtoIndyProofRequestPayloador something similar to separate it out from presentation exchange payload - @ankita-p17 Thoughts ?
There was a problem hiding this comment.
Agree @sairanjit, @pallavighule please commit this update in subsequent PR to keep the separation of formats.
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com> Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com> Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com> Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks 8000 .com>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 12, 2024
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com> Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank
pushed a commit
that referenced
this pull request
Sep 12, 2024
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com> Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What