Add KeyChain support #813
Open
Add KeyChain support #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [cachix/cachix-action](https://github.com/cachix/cachix-action) from 15 to 16. - [Release notes](https://github.com/cachix/cachix-action/releases) - [Commits](cachix/cachix-action@v15...v16) --- updated-dependencies: - dependency-name: cachix/cachix-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
eirnym
approved these changes
Mar 24, 2025
eirnym
approved these changes
Mar 24, 2025
zakarumych
approved these changes
Mar 24, 2025
|
LGTM, please ping me in a day or two if doesn't get any response. |
|
@dpc any news? |
kornelski
reviewed
Apr 7, 2025
| @@ -10,6 +10,8 @@ use term::{ | |||
| StderrTerminal, StdoutTerminal, | |||
| }; | |||
|
|
|||
| use crate::creds; | |||
There was a problem hiding this comment.
I've fixed the problem. Sorry for the delay
4f06cae to
1c146b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mac keychain basic support - without unlocked session, just ordinary get/set.
It needed to mode safely (and friendly!) store and retrieve passphrases then from env or shell.
Checklist:
cargo +nightly fmt --allCHANGELOG.mdif applicable