8000 Put intermediate build files in BUILD directory by AlexanderplUs · Pull Request #149 · creytiv/re · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Put intermediate build files in BUILD directory #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Put intermediate build files in BUILD directory #149

wants to merge 3 commits into from

Conversation

AlexanderplUs
Copy link
Contributor

I've changed Makefile to put resulted libre.a, libre.so and libre.pc in output BUILD directory. It is very useful during cross-compilation for different architectures. And it is common for all libraries with Makefiles.

@alfredh
Copy link
Contributor
alfredh commented Aug 3, 2018

hi @AlexanderplUs

many thanks.

could you please split this PR into 2 PRs ? one PR with adding the PKG_CONFIG
variable and one PR with moving the libs.

did you test that the make install target is still working ? could you also
test if make deb and make rpm still works ?

the path change will break some other project that uses libre,
for example baresip-android:

https://github.com/alfredh/baresip-android

so we also need to find a solution for that ..

@AlexanderplUs
Copy link
Contributor Author
AlexanderplUs commented Aug 13, 2018 •
edited
Loading

Ok, I'll split PR in 2 PRs.

make install, make deb and make rpm works fine.
Path change may break only projects that doesn't use libraries from install directory which is dangerous anyway.

@alfredh
Copy link
Contributor
alfredh commented Aug 16, 2018

thanks @AlexanderplUs

I agree that projects should not use direct path to libre.a :)

@alfredh
Copy link
Contributor
alfredh commented Sep 2, 2018

I will close this now, please open 2 PRs as requested.

@alfredh alfredh closed this Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderplUs @alfredh @Alexander-Ushakov
0