Allow to work on pull_request and master branch #3

adriaandotcom · 2020-01-16T14:29:23Z

Not sure if this is possible, but it would be nice to have only one step instead of these two:

- name: Prettier Action on PR
  if: github.event_name == 'pull_request'
  uses: creyD/prettier_action@v1.0
  with:
    prettier_options: "--write {**/*,*}.{js,html,json,md,yml,css,scss}"
    branch: ${{ github.head_ref }}
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Prettier Action on master
  if: github.event_name == 'push' && github.ref == 'refs/heads/master'
  uses: creyD/prettier_action@v1.0
  with:
    prettier_options: "--write {**/*,*}.{js,html,json,md,yml,css,scss}"
    branch: master
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Somehow it would be nice to not have to specify a branch. That is automatically would know if it's a PR or if it's just a push. If it's not available in your app than we could do something like this:

- name: Prettier Action
  uses: creyD/prettier_action@v1.0
  with:
    prettier_options: "--write {**/*,*}.{js,html,json,md,yml,css,scss}"
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    event_name: ${{ github.event_name }}
    ref: ${{ github.ref }}

creyD · 2020-01-16T16:06:57Z

This isn't really possible because -as for the GITHUB_TOKEN-, my repository and therefore the Action can't access the issuing (your) repository. Even if you provide the event name, my action doesn't know where to push to. If you just only want to merge to the origin branch, then this should do the job -the on parameter is documented here:

on: [push, pull_request]
- name: Prettier Action on master
  if: github.event_name == 'push' && github.ref == 'refs/heads/master'
  uses: creyD/prettier_action@v1.0
  with:
    prettier_options: "--write {**/*,*}.{js,html,json,md,yml,css,scss}"
    branch: ${{ github.ref }}
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

The branch SHOULD be filled with master automatically if it's the on push event.

adriaandotcom · 2020-01-16T18:26:20Z

I'm already using the on parameter like this:

on:
  pull_request:
    types: [opened, synchronize]
  push:
    branches:
      - master

Which works great.

I think I'm not clear on what I would love to have. I would love that the GitHub Action would work without specifying the branch. Or where it would work for both a PR and for a normal push.

Maybe this works?

on:
  pull_request:
    types: [opened, synchronize]
  push:
    branches:
      - master

jobs:
  build:
    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [12.x]

    steps:
      - name: Prettier Action on master
        uses: creyD/prettier_action@v1.0
        with:
          prettier_options: "--write {**/*,*}.{js,html,json,md,yml,css,scss}"
          branch: ${{ github.head_ref || github.ref }}
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Note the branch name: ${{ github.head_ref || github.ref }}.

creyD · 2020-01-17T08:31:03Z

I think you could do this with an if statement in your code. ${{ github.head_ref || github.ref }} won't work, but if you implement this functionality with a if else statement, it should work!

adriaandotcom · 2020-01-17T10:39:28Z

Thanks, will try!

Fix regex issue

adriaandotcom added the enhancement New feature or request label Jan 16, 2020

adriaandotcom closed this as completed Jan 17, 2020

creyD pushed a commit that referenced this issue Jan 10, 2021

Merge pull request #3 from sebastianks/check-plugin-name

d8e72fc

Fix regex issue

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to work on pull_request and master branch #3

Allow to work on pull_request and master branch #3

Allow to work on pull_request and master branch #3

Allow to work on pull_request and master branch #3

Comments