8000 Revert "Skip `[sig-network] KubeProxy should update metric…` test" by haircommander · Pull Request #8577 · cri-o/cri-o · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Skip [sig-network] KubeProxy should update metric… test" #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "Skip [sig-network] KubeProxy should update metric… test" #8577

wants to merge 1 commit into from
+0 −3

Conversation

haircommander
Copy link
Member
@haircommander haircommander commented Sep 9, 2024 •
edited
Loading

This reverts commit 6af15ae.

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

per #8270 (comment)
fixes #8270

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander
Revert "Skip [sig-network] KubeProxy should update metric… test"
d204f7b 
This reverts commit 6af15ae.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 9, 2024
@openshift-ci openshift-ci bot requested review from klihub and littlejawa September 9, 2024 14:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@codecov Codecov
Copy link
codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.28%. Comparing base (44e0241) to head (d204f7b).
Report is 544 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8577      +/-   ##
==========================================
+ Coverage   49.25%   49.28%   +0.02%     
==========================================
  Files         153      153              
  Lines       17254    17305      +51     
==========================================
+ Hits         8498     8528      +30     
- Misses       7688     7716      +28     
+ Partials     1068     1061       -7
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@saschagrunert
Copy link
Member

/retest

1 similar comment
@sohankunkerkar
Copy link
Member

/retest

@sohankunkerkar sohankunkerkar mentioned this pull request Sep 16, 2024
Open
@saschagrunert
Copy link
Member

/retest

@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski
Copy link
Contributor

@cri-o/cri-o-maintainers, please have a look. Thank you!

@saschagrunert
Copy link
Member

/retest

1 similar comment
@sohankunkerkar
Copy link
Member

/retest

@saschagrunert
Copy link
Member

So the failures are legit, the issue is not fixed.

@kwilczynski
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2024
@kwilczynski kwilczynski removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@danwinship
Copy link
Contributor

So the failures are legit, the issue is not fixed.

@aroradaman

I0919 14:11:01.803215 90582 builder.go:121] Running '/usr/go/src/k8s.io/kubernetes/_output/bin/kubectl --server=https://10.0.0.2:6443 --kubeconfig=/var/run/kubernetes/admin.kubeconfig --namespace=kube-proxy-5674 exec host-exec-pod -- /bin/sh -x -c curl --silent 127.0.0.1:10249/proxyMode'
I0919 14:11:01.918647 90582 builder.go:146] stderr: "+ curl --silent 127.0.0.1:10249/proxyMode\n"
I0919 14:11:01.918678 90582 builder.go:147] stdout: "iptables"
I0919 14:11:01.918735 90582 builder.go:121] Running '/usr/go/src/k8s.io/kubernetes/_output/bin/kubectl --server=https://10.0.0.2:6443 --kubeconfig=/var/run/kubernetes/admin.kubeconfig --namespace=kube-proxy-5674 exec host-exec-pod -- /bin/sh -x -c cat /proc/sys/net/ipv4/conf/all/route_localnet'
I0919 14:11:02.003870 90582 builder.go:146] stderr: "+ cat /proc/sys/net/ipv4/conf/all/route_localnet\n"
I0919 14:11:02.003902 90582 builder.go:147] stdout: "1\n"

...

I0919 14:10:59.684522 90582 kube_proxy.go:305] Unexpected error: 
    <*errors.errorString | 0xc001366840>: 
    metric 'kubeproxy_iptables_localhost_nodeports_accepted_packets_total' not found
    {
        s: "metric 'kubeproxy_iptables_localhost_nodeports_accepted_packets_total' not found",
    }

@aroradaman
Copy link
aroradaman commented Oct 17, 2024 •
edited
Loading

Looks like the nfacct module is not available.

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/cri-o_cri-o/8577/pull-ci-cri-o-cri-o-main-ci-crun-e2e/1836763583229202432/artifacts/crun-e2e/cri-o-gather/artifacts/kube-proxy.log

I0919 14:03:42.950672   80065 proxier.go:278] "Using iptables mark for masquerade" ipFamily="IPv4" mark="0x00004000"
E0919 14:03:42.952846   80065 proxier.go:283] "Failed to create nfacct runner, nfacct based metrics won't be available" err="nfacct sub-system not available" ipFamily="IPv4"
I0919 14:03:42.952877   80065 proxier.go:324] "Iptables sync params" ipFamily="IPv4" minSyncPeriod="1s" syncPeriod="30s" burstSyncs=2
I0919 14:03:42.952907   80065 proxier.go:334] "Iptables supports --random-fully" ipFamily="IPv4"
I0919 14:03:42.952956   80065 proxier.go:278] "Using iptables mark for masquerade" ipFamily="IPv6" mark="0x00004000"
E0919 14:03:42.954383   80065 proxier.go:283] "Failed to create nfacct runner, nfacct based metrics won't be available" err="nfacct sub-system not available" ipFamily="IPv6"
I0919 14:03:42.954424   80065 proxier.go:324] "Iptables sync params" ipFamily="IPv6" minSyncPeriod="1s" syncPeriod="30s" burstSyncs=2
I0919 14:03:42.954449   80065 proxier.go:334] "Iptables supports --random-fully" ipFamily="IPv6"
I0919 14:03:42.954479   80065 server.go:483] "Version info" version="v1.32.0-alpha.0.825+ae945462fb2d12"
I0919 14:03:42.954507   80065 server.go:485] "Golang settings" GOGC="" GOMAXPROCS="" GOTRACEBACK=""
E0919 14:03:42.956443   80065 metrics.go:340] "failed to initialize nfacct client" err="nfacct sub-system not available"
E0919 14:03:42.957890   80065 metrics.go:340] "failed to initialize nfacct client" err="nfacct sub-system not available"

With the current behavior metrics won't be registered is the sub-system is not available.
https://github.com/kubernetes/kubernetes/blob/v1.32.0-alpha.1/pkg/proxy/metrics/metrics.go#L304-L307

E0919 14:03:42.956443   80065 metrics.go:340] "failed to initialize nfacct client" err="nfacct sub-system not available"
E0919 14:03:42.957890   80065 metrics.go:340] "failed to initialize nfacct client" err="nfacct sub-system not available"

@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2024
@sohankunkerkar sohankunkerkar removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 16, 2025
@sohankunkerkar
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Jan 16, 2025

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-cgroupv2-e2e d204f7b link true /test ci-cgroupv2-e2e
ci/prow/ci-rhel-e2e d204f7b link true /test ci-rhel-e2e
ci/prow/ci-crun-e2e d204f7b link true /test ci-crun-e2e
ci/prow/ci-e2e d204f7b link true /test ci-e2e
ci/prow/ci-e2e-conmonrs d204f7b link true /test ci-e2e-conmonrs
ci/prow/ci-cgroupv2-e2e-crun d204f7b link true /test ci-cgroupv2-e2e-crun
ci/prow/ci-e2e-evented-pleg d204f7b link true /test ci-e2e-evented-pleg

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kwilczynski kwilczynski removed their assignment Feb 10, 2025
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2025
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2025
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KubeProxy test failing
< 3BC0 /div>
6 participants
@haircommander @saschagrunert @sohankunkerkar @kwilczynski @danwinship @aroradaman
0