Move to IRQBALANCE_BANNED_CPULIST #8931
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tal-or The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Supersede for: #8783 |
|
/cc @MarSik |
|
@Tal-or: GitHub didn't allow me to request PR reviews from the following users: MarSik. Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8931 +/- ##
==========================================
- Coverage 66.92% 66.41% -0.51%
==========================================
Files 198 198
Lines 27176 27236 +60
==========================================
- Hits 18187 18090 -97
- Misses 7488 7642 +154
- Partials 1501 1504 +3 🚀 New features to boost your workflow:
|
0cd6a17 to
b3da2f9
Compare
7eff2b5 to
8a7d734
Compare
|
/retest-required |
| if strings.HasPrefix(line, irqBalanceBannedCpusLegacy+"=") { | ||
| list := strings.Trim(strings.Split(line, "=")[1], "\"") | ||
|
|
||
| return mapHexCharToCPUSet(list) |
There was a problem hiding this comment.
What if both are present at the same time?
There was a problem hiding this comment.
It will preferred and go through the legacy flow first and only once.
On the next iteration the legacy value will be commented out and the new value will be used.
920cd04 to
f762eb0
Compare
|
/retest |
|
A friendly reminder that this PR had no activity for 30 days. |
|
/lifecycle/stale remove |
|
/retest |
|
A friendly reminder that this PR had no activity for 30 days. |
|
/retest |
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
add helper functions for manipulating different CPU set representaition. The unit-tests have been adjusted for validating the new helper functions. Signed-off-by: Talor Itzhak <titzhak@redhat.com> Co-authored-by: Martin Sivak <msivak@redhat.com>
f762eb0 to
19e93fc
Compare
The IRQBALANCE_BANNED_CPUS variable is deprecated and will not be used anymore in the near future. The newer IRQBALANCE_BANNED_CPULIST variable is already supported by irqbalanced (https://github.com/Irqbalance/irqbalance/blob/v1.9.0/cputree.c#L135) and should be used. Implementing this requires new code for byte/hex formatted cpu mask to CPUSet formatting code. Co-authored-by: Martin Sivak <msivak@redhat.com> Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
19e93fc to
1b67284
Compare
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
1b67284 to
0ba1338
Compare
|
/retest |
1 similar comment
|
/retest |
|
@Tal-or: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
The IRQBALANCE_BANNED_CPUS variable is deprecated and will not be used anymore in the near future.
The newer IRQBALANCE_BANNED_CPULIST variable is already supported by irqbalanced (https://github.com/Irqbalance/irqbalance/blob/v1.9.0/cputree.c#L135) and should be used.
Implementing this requires new code for byte/hex formatted cpu mask to CPUSet formatting code.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?