-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for CNAI models #9131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chlins do you mind giving this PR a try as well? It should work for both, |
@saschagrunert Thanks for the quick fix, I'll try it out based on this PR. |
cdaceb0
to
23035a4
Compare
@saschagrunert I've verified the PR with both raw and tar format, all can be mounted successfully, currently crio did not do the untar operation, but I think it's another topic or feature request. Thanks! |
/retest |
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
23035a4
to
ab9acb6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9131 +/- ##
==========================================
- Coverage 47.02% 47.00% -0.02%
==========================================
Files 161 161
Lines 23617 23630 +13
==========================================
+ Hits 11105 11108 +3
- Misses 11414 11422 +8
- Partials 1098 1100 +2 🚀 New features to boost your workflow:
|
/override ci/prow/ci-e2e-evented-pleg |
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg, ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding support for CNAI models.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Fixes #9127
Does this PR introduce a user-facing change?