adds container_start_time_seconds metric #9282
Conversation
Signed-off-by: Shwejan Raj, Bhupathi <Bhupathi.ShwejanRaj@fmr.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shwejanraj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @shwejanraj. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@shwejanraj Thank you for the PR. Can you fill in the description and the release note? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9282 +/- ##
===========================================
- Coverage 66.92% 56.12% -10.80%
===========================================
Files 198 199 +1
Lines 27176 27320 +144
===========================================
- Hits 18187 15333 -2854
- Misses 7488 10487 +2999
+ Partials 1501 1500 -1 🚀 New features to boost your workflow:
|
I overlooked them..sorry for that. I have added those now. |
Signed-off-by: Bhupathi Shwejan Raj <Bhupathi.ShwejanRaj@fmr.com>
cad5b52 to
8d2c172
Compare
|
@bitoku. Can you please review the PR. |
|
/ok-to-test |
There was a problem hiding this comment.
Can you add e2e test for this change?
You can refer to this https://github.com/cri-o/cri-o/tree/main/test.
internal/lib/stats/descriptors.go
Outdated
| var ( | ||
| containerStartTimeSeconds = &types.MetricDescriptor{ | ||
| Name: "container_start_time_seconds", | ||
| Help: "Start time of the container since unix epoch", |
There was a problem hiding this comment.
| Help: "Start time of the container since unix epoch", | |
| Help: "Start time of the container since unix epoch in seconds.", |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@shwejanraj: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a new metric,
container_start_time_seconds, to the CRI-O metrics. This metric exposes the start time of containers (in seconds since the Unix epoch), enabling observability and monitoring tools to track the precise start events of containers via the metrics endpoint.Which issue(s) this PR fixes:
9125
Special notes for your reviewer:
Does this PR introduce a user-facing change?