8000 Updated version of criocli.go with log.Warnf by gmarav05 · Pull Request #9317 · cri-o/cri-o · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updated version of criocli.go with log.Warnf #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated version of criocli.go with log.Warnf #9317

wants to merge 2 commits into from
+10 −0

Conversation

gmarav05
Copy link
@gmarav05 gmarav05 commented Jul 2, 2025

What type of PR is this?

This PR Logs warning when CONTAINER_INCLUDED_POD_METRCIS(typo) is used. Updated GetFlagsAndMetadata() in internal/criocli/criocli.go

What this PR does / why we need it:

It Logs warning when CONTAINER_INCLUDED_POD_METRCIS(typo) is used. instead of CONTAINER_INCLUDED_POD_METRICS.

Which issue(s) this PR fixes:

It fixes #9300 and Warns when CONTAINER_INCLUDED_POD_METRCIS is used.

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- Logs Warning for using CONTAINER_INCLUDED_POD_METRCIS(typo).

gmarav05 added 2 commits July 2, 2025 17:22
@gmarav05
updated criocli.go
1e20682 
Signed-off-by: Gm Aravind <gmarav005@gmail.com>
@gmarav05
updated logrus with log.Warnf in internal/criocli/criocli.go
5fb7636 
Signed-off-by: Gm Aravind <gmarav005@gmail.com>
@gmarav05 gmarav05 requested a review from mrunalp as a code owner July 2, 2025 17:45
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 2, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and klihub July 2, 2025 17:45
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 2, 2025
@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Jul 2, 2025

Hi @gmarav05. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2025
@klihub
Copy link
Contributor
klihub commented Jul 3, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gmarav05, klihub
Once this PR has been reviewed and has the lgtm label, please assign fidencio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Jul 3, 2025

@gmarav05: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 5fb7636 link true /test e2e-aws-ovn
ci/prow/ci-cgroupv2-e2e-features 5fb7636 link true /test ci-cgroupv2-e2e-features
ci/prow/e2e-gcp-ovn 5fb7636 link true /test e2e-gcp-ovn
ci/prow/images 5fb7636 link true /test images
ci/prow/ci-cgroupv2-e2e 5fb7636 link true /test ci-cgroupv2-e2e
ci/prow/ci-rhel-critest 5fb7636 link true /test ci-rhel-critest
ci/prow/ci-fedora-critest 5fb7636 link true /test ci-fedora-critest
ci/prow/ci-rhel-e2e 5fb7636 link true /test ci-rhel-e2e
ci/prow/ci-crun-e2e 5fb7636 link true /test ci-crun-e2e
ci/prow/ci-e2e-conmonrs 5fb7636 link true /test ci-e2e-conmonrs
ci/prow/ci-cgroupv2-integration 5fb7636 link true /test ci-cgroupv2-integration
ci/prow/ci-e2e 5fb7636 link true /test ci-e2e
ci/prow/ci-e2e-evented-pleg 5fb7636 link false /test ci-e2e-evented-pleg
ci/prow/ci-cgroupv2-e2e-crun 5fb7636 link true /test ci-cgroupv2-e2e-crun
ci/prow/ci-fedora-kata 5fb7636 link true /test ci-fedora-kata
ci/prow/ci-fedora-integration 5fb7636 link true /test ci-fedora-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gmarav05
Copy link
Author
gmarav05 commented Jul 4, 2025

if you dont mind, is there something wrong in my PR these tests are failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@klihub klihub Awaiting requested review from klihub

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn when CONTAINER_INCLUDED_POD_METRCIS is used
3 participants
@gmarav05 @klihub @saschagrunert
0