8000 Implement auth settings form by lightnet328 · Pull Request #707 · crowi/crowi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement auth settings form #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Implement auth settings form #707

wants to merge 17 commits into from

Conversation

lightnet328
Copy link
Member

WHAT

  • Implement auth settings form

localhost_3000_admin_app(iPad Pro)

WHY

@lightnet328 lightnet328 force-pushed the feat/auth-settings-form branch from e561758 to ab164fe Compare August 8, 2020 21:09
@sotarok sotarok temporarily deployed to crowi-dev-pr-707 August 8, 2020 21:10 Inactive
@codecov
Copy link
codecov bot commented Aug 8, 2020 •
edited
Loading

Codecov Report

Merging #707 (483a4db) into master (79d3b58) will decrease coverage by 0.03%.
The diff coverage is 23.11%.

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   22.44%   22.41%   -0.04%     
==========================================
  Files         268      274       +6     
  Lines        7555     7726     +171     
  Branches     1156     1173      +17     
==========================================
+ Hits         1696     1732      +36     
- Misses       4781     4902     +121     
- Partials     1078     1092      +14
Impacted Files Coverage Δ
client/components/Admin/App/AWSSettings.tsx 0.00% <0.00%> (ø)
client/components/Admin/App/AppPage.tsx 0.00% <ø> (ø)
client/components/Admin/App/AuthSettings.tsx 0.00% <0.00%> (ø)
client/components/Admin/App/SecuritySettings.tsx 0.00% <0.00%> (ø)
client/components/Admin/Navigation.tsx 0.00% <0.00%> (ø)
client/components/Admin/TopPage.tsx 0.00% <0.00%> (ø)
client/components/Admin/User/InviteUserForm.tsx 0.00% <0.00%> (ø)
client/components/Admin/User/InvitedUserModal.tsx 0.00% <0.00%> (ø)
...lient/components/Admin/User/ResetPasswordModal.tsx 0.00% <0.00%> (ø)
client/components/Admin/User/UserEditDropdown.tsx 0.00% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d3b58...483a4db. Read the comment docs.

@sotarok
Copy link
Member
sotarok commented Aug 9, 2020

Code is okay 🙆‍♂️
But I'll check the behavior by this settings.

@sotarok
Copy link
Member
sotarok commented Aug 15, 2020

⚡ Found a bug, this may not directly related to this PR though ... an error occurred when

  • Set a domain to the allowing list of registering email address
  • Access to the user settings page /me

then following error occurred.

image

sotarok
sotarok reviewed Aug 15, 2020
View reviewed changes
Copy link
Member
@sotarok sotarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other behaviors except I figured out above are okay.
@lightnet328 Can you fix the problem on this PR?

@sotarok sotarok self-assigned this Jul 16, 2022
@sotarok sotarok deleted the branch master August 1, 2022 07:18
@sotarok sotarok closed this Aug 1, 2022
@sotarok sotarok mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotarok sotarok sotarok left review comments

@otofune otofune Awaiting requested review from otofune

@saitolume saitolume Awaiting requested review from saitolume

Assignees

@sotarok sotarok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lightnet328 @sotarok @suzuki
0