feat(media_player): add default init volume #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60c9f52 to
15c126b
Compare
15c126b to
144c688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional attribute for the Media Player alert - default_init_volume.
When the alarm is triggered, Home Alarm collects the current volume level of all media player to then restore initial volume once alarm is stopped (btw, love this feature!). However, some media players do not support
volume_levelwhen they are turned off, so the attribute cannot be retrieved and it is marked asNone. Then, when it tries to restore it, the code fails since it cannot change volume toNone.This PR adds a default init volume option for such cases. So, if the retrieved volume from the media player is
None, then it will be assigned thedefault_init_volumevalue. If the media players contain thevolume_levelbefore turning on, then, nothing will change for those.