8000 migrated from Guava Cache to Caffeine by overheadhunter · Pull Request #164 · cryptomator/cryptofs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

migrated from Guava Cache to Caffeine #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

migrated from Guava Cache to Caffeine #164

merged 1 commit into from
Mar 30, 2023

Conversation

overheadhunter
Copy link
Member

fixes #162

@overheadhunter overheadhunter added this to the 2.6.3 milestone Mar 24, 2023
@overheadhunter overheadhunter requested a review from infeo March 24, 2023 10:34
infeo
8000 infeo approved these changes Mar 24, 2023
View reviewed changes
@infeo
Copy link
Member
infeo commented Mar 28, 2023

I gave this PR another look and noticed, that we have different handling of the UncheckedIOExceptions:

  1. Rewrap it in a generic IOException, loosing direct type information about what failed (e.g., https://github.com/cryptomator/cryptofs/pull/164/files#diff-2261d9d07dd9f059e74785d49eb7ed731d267b4f53eb030617ac116fe22b9ad6R161-R170)
  2. Unwrap and rethrow the cause, as done in https://github.com/cryptomator/cryptofs/pull/164/files#diff-bda48bb261f4b28cb28912d63eaffd3f12979360757e812b8f45784be17ac850L73-L80

@overheadhunter What is the logic behind it?

@overheadhunter
Copy link
Member Author

The latter is to satisfy unit tests that expect to catch a NoSuchFileException instead of a generic IOException. Not sure if this is just for tests or actually needed downstream, but I thought I better not change the behavior of public API.

@infeo infeo merged commit 32650a9 into develop Mar 30, 2023
@infeo infeo deleted the feature/caffeine branch March 30, 2023 14:49
@tobihagemann tobihagemann changed the title migrated from Guava Cache to Coffeine migrated from Guava Cache to Caffeine Nov 3, 2023
@infeo infeo mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infeo infeo infeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.

Replace Guava Cache with Caffeine
2 participants
@overheadhunter @infeo
0