Proof-read PR387 #411
Proof-read PR387 #411
Conversation
| like a :term:`stream cipher`. These configurations are commonly called | ||
| :term:`mode of operation`\s. They aren't specific to a particular block cipher. | ||
| like a :term:`stream cipher`. These configurations are known as | ||
| :term:`mode of operation`\s. They are not specific to a particular block cipher. |
There was a problem hiding this comment.
@lvh ,
"They are not specific..."
Can this change to note that different modes are available?
There was a problem hiding this comment.
I'm not sure i understand, can you elaborate?
There was a problem hiding this comment.
"They are not specific to a particular block cipher."
Are you trying to say different modes of operations can be applied to block ciphers other than AES?
There was a problem hiding this comment.
I'm trying to say that modes of operation (I don't count e.g. AEZ as a real mode of operation) are defined independently of block ciphers. You can do AES-CBC, but also 3DES-CBC. I'm trying to say all modes of operation work on all block ciphers, with very few edge cases.
There was a problem hiding this comment.
Yup that's how I understood it
What I didn't know is if the beginning word "They" is correctly representing mode of operations or "These configurations" (from previous sentence)
There was a problem hiding this comment.
Hm, gotcha. The previous sentence just defines the name, so since "configurations" and "modes of operation" are the same thing I guess I don't see it as confusing, but if you want to replace the They with "modes of operation" that's fine
There was a problem hiding this comment.
That makes sense. I don't think it needs to be changed. Thanks for explaining.
|
@lvh , All your feedback are applied to this PR now |
src/stream-ciphers.rst
Outdated
| Suppose there is a database storing secret user information, like medical, | ||
| payroll or criminal records. The server protects the information by encrypting | ||
| it with a strong block cipher in :term:`CBC mode` with a fixed key. For now, we | ||
| assume the server is secure, and no way for a key leak. |
There was a problem hiding this comment.
"for the key to leak" seems better, I've never heard "key leak" in this sense
There was a problem hiding this comment.
Updated just now :)
|
Looks great! Thanks! |
I have 4 things to note