Add pop/push size per instruction #116

montyly · 2022-12-13T09:54:53Z

No description provided.

CLAassistant · 2022-12-13T09:54:58Z

All committers have signed the CLA.

montyly · 2022-12-13T10:21:09Z

TODO: improve testing coverage so that we cover the new code

S3v3ru5 · 2022-12-14T13:28:42Z

tealer/teal/instructions/instructions.py

+    @property
+    def stack_push_size(self) -> int:
+        return 1
+

 class Txn(Instruction):


Add stack_push_size = 1 for Txn instruction

great catch

S3v3ru5 · 2022-12-14T14:14:36Z

tealer/teal/instructions/instructions.py

+    @property
+    def stack_push_size(self) -> int:
+        return 2
+

 class Global(Instruction):


Add stack_push_size = 1 for Global Instruction

S3v3ru5 · 2022-12-14T14:17:56Z

tealer/teal/instructions/instructions.py

+    @property
+    def stack_push_size(self) -> int:
+        return 1
+

 class Cover(Instruction):


Add stack_pop_size = 1 + self._idx and stack_push_size = 1 + self._idx to cover instruction (?)

S3v3ru5 · 2022-12-14T14:20:55Z

tealer/teal/instructions/instructions.py

@@ -1444,6 +1736,10 @@ def __init__(self) -> None:
    def __str__(self) -> str:


Add stack_push_size = 1 for AppGlobalGet (app_global_get) instruction.

S3v3ru5 · 2022-12-14T14:38:51Z

tealer/teal/instructions/instructions.py

+    @property
+    def stack_push_size(self) -> int:
+        return 1
+

 class Addr(Instruction):


add stack_push_size = 1 for Addr instruction.

S3v3ru5 · 2022-12-14T14:45:58Z

tealer/teal/instructions/instructions.py

@@ -2678,6 +3346,14 @@ def cost(self) -> int:
            return 4
        return 0

+    @property
+    def stack_pop_size(self) -> int:
+        return 2


Update to stack_pop_size = 1 for BBitwiseInvert (b~) instruction

S3v3ru5 · 2022-12-14T14:54:26Z

tealer/teal/instructions/instructions.py

+    @property
+    def stack_push_size(self) -> int:
+        return 1
+

 class Intc3(Instruction):


Add stack_push_size = 1 for Intc3

S3v3ru5 · 2022-12-14T16:15:51Z

tealer/teal/instructions/instructions.py

+    @property
+    def stack_push_size(self) -> int:
+        return 1
+

 class Substring3(Instruction):


Add stack_push_size = 1 and stack_pop_size = 3 to Substring3 Instruction

S3v3ru5 · 2022-12-14T16:19:12Z

tealer/teal/instructions/instructions.py

@@ -3760,6 +4676,10 @@ def field(self) -> TransactionField:
        """Array transaction field being accessed."""
        return self._field



Add stack_pop_size = 1 to Itxnas instruction

S3v3ru5 · 2022-12-14T16:23:42Z

tealer/teal/instructions/instructions.py

@@ -3903,6 +4847,14 @@ def start_position(self) -> int:
            raise TealerException("replace instruction does not have any immediates")
        return self._idx

+    @property


Number of values popped depends on the immediate argument s. If there's no immediate argument then, replace is replace3 and stack_pop_size = 3. If there is a immediate argument then replace s is equivalent to replace2 s and stack_pop_size = 2.

S3v3ru5 · 2022-12-14T16:32:34Z

tealer/teal/instructions/instructions.py

@@ -4142,6 +5142,14 @@ def __init__(self, index: int):
        self._index: int = index
        self._version: int = 8



bury n: should we set the pop size to n + 1 and push size to n? I don't know if the stack depth n includes A value or not.

S3v3ru5 · 2022-12-14T16:35:38Z

tealer/teal/instructions/instructions.py

@@ -4164,6 +5172,10 @@ def __init__(self, n: int):
        self._nelements: int = n
        self._version: int = 8
              


            
+    @property


Add stack_pop_size = n and update stack_push_size to 0 for Popn instruction

S3v3ru5 · 2022-12-14T16:39:11Z

tealer/teal/instructions/instructions.py

@@ -4183,6 +5195,10 @@ def __init__(self, count: int):
        self._count: int = count
        self._version: int = 8

+    @property


Update stack_push_size = n + 1 and stack_pop_size = 1 for Dupn instruction

S3v3ru5 · 2022-12-14T16:40:47Z

tealer/teal/instructions/instructions.py

@@ -4204,6 +5220,10 @@ def __init__(self, bytes_list: List[str]):
        self._bytes_list = bytes_list
        self._version: int = 8

+    @property
+    def stack_push_size(self) -> int:
+        return 1


update stack_push_size = len(self._bytes_list) for PushBytess instruction.

S3v3ru5 · 2022-12-14T16:41:39Z

tealer/teal/instructions/instructions.py

@@ -4225,6 +5245,10 @@ def __init__(self, int_list: List[int]):
        self._int_list = int_list
        self._version: int = 8

+    @property
+    def stack_push_size(self) -> int:
+        return 1


update stack_push_size = len(self._int_list) for PushInts instruction.

frabert and others added 2 commits December 12, 2022 14:53

Add in/out info for instructions

0cd9354

Improvements

1be8aba

montyly requested a review from S3v3ru5 December 13, 2022 09:54

S3v3ru5 reviewed Dec 14, 2022

View reviewed changes

montyly and others added 4 commits December 14, 2022 14:53

Update instructions.py

1d1714b

Update instructions.py

68327fa

Fix

7a66258

Merge branch 'dev' into dev-instruction-pop-push

8233995

S3v3ru5 reviewed Dec 14, 2022

View reviewed changes

montyly mentioned this pull request Dec 14, 2022

Add generic dataflow framework + example + stack value analysis #118

Draft

S3v3ru5 reviewed Dec 14, 2022

View reviewed changes

Vara Prasad Bandaru added 2 commits December 19, 2022 17:34

Fix instruction push, pop sizes and add unit tests for it

812dfb1

Fix black linter error

dc6d1fe

montyly merged commit 76e3d2f into dev Dec 20, 2022

montyly deleted the dev-instruction-pop-push branch December 20, 2022 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add pop/push size per instruction #116

Add pop/push size per instruction #116

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

		@@ -1444,6 +1736,10 @@ def __init__(self) -> None:
		def __str__(self) -> str:

		@@ -3760,6 +4676,10 @@ def field(self) -> TransactionField:
		"""Array transaction field being accessed."""
		return self._field

		@@ -4142,6 +5142,14 @@ def __init__(self, index: int):
		self._index: int = index
		self._version: int = 8

Add pop/push size per instruction #116

Add pop/push size per instruction #116

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!