8000 feat: analysis support for builtin modules by werifu · Pull Request #8 · cs-au-dk/jelly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: analysis support for builtin modules #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat: analysis support for builtin modules #8

wants to merge 13 commits into from

Conversation

werifu
Copy link
@werifu werifu commented Mar 23, 2023 •
edited
Loading

Hi @amoeller , I have done some work on supporting builtin modules of Node.js using an approach o 8000 f mock as what you have taught me at last meeting.

I'm not sure if it's correct to mock the APIs by the method in my code, therefore I only wrote 4 modules related with module 'http' at the moment and I hope you could review it.

Please let me introduce what I have done in this PR:

  1. in src/analysis/operation.ts: I removed the code about adding Unknown Access Path for builtin modules since it would be handled correctly when resolving the file.
  2. in src/misc/files.ts: the function resolveBultinModule would do what tsResolveModuleName does but only for builtin modules.
  3. in src/packagejson.ts: I processed the package information of builtin modules shown on the graph.
  4. in src/mockbuiltin/*.js: They are the mock APIs of respective builtin modules, all functions and methods in them do the same thing: treating all arguments as functions and call them so that callbacks passed into the APIs would be called in user's code. Since we will not execute the code in mockbuiltin, we don't need to consider potential runtime errors.

I'm now still working for the rest APIs in builtin modules, but I need your advice before I continue this work in order to avoid meaningless work...
It also bothers me that how can I perform unit tests on all mocked APIs to guarantee the correctness.

I will appreciate it a lot If you could review my code and instruct me in this PR.

@werifu werifu changed the title feat(WIP): resolve std libs about http feat(WIP): analysis support for builtin modules Mar 23, 2023
@werifu werifu marked this pull request as ready for review May 9, 2023 13:39
@werifu werifu changed the title feat(WIP): analysis support for builtin modules feat: analysis support for builtin modules May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@werifu
0