docs: update Marketplace Favorites spec to favwc implementation #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autograder for Marketplace Milestone 4 now checks for the <dj4e-favstar> web-component implemented in the `favwc` sample app. The published assignment still tells students to adapt the older `favs` app, which won't pass the autograder.
This patch updates dj4e_mkt4.md to:
* Reference `favwc` instead of `favs`
* Use a single `ad_toggle` url path and `ToggleFavoriteView`
* Show the Lit-based `dj4e-favstar.js` web component Javascript implementation
* Fix minor typos and add explicit `{% load static %}` / script tag notes
|
Wow - I dropped the ball on this one - thanks for all the catches. |
|
You have become the #3 contributor! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autograder for Marketplace Milestone 4 now checks for the web-component implemented in the
favwcsample app. The published assignment still tells students to adapt the olderfavsapp, which won't pass the autograder.This patch updates dj4e_mkt4.md to:
favwcinstead offavsad_toggleurl path andToggleFavoriteViewdj4e-favstar.jsweb component Javascript implementation{% load static %}/ script tag notes