fix slice low/high index shadowing variables in vm #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ipsusila did you mean to add the encode/decode to this PR? |
|
@geseq I'm sorry that the PR is confusing. After I submitting the PR which is the fix for low/high variables, I add commit which includes Encode/Decode to For Encode/Decode feature, I need your suggestions, wether it's acceptable to add such feature. If yes, should I separate the PR, or can we simply change the title and submit both PR? |
|
No worries at all. Ideally please move it to a separate PR. I’ll take a look at it later. |
|
Thank you @geseq I revert Encode/Decode related commit from PR. For Encode/decode, later I will submit the PR. |
geseq
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables
lowandhighare being shadowed. Therefore, when slice index is invalid (not aninteger), the error message does not gives correct invalid type hint, and always returnRuntime Error: invalid slice index type: int