8000 bugfix: parse expect error when mis match braces by sailinglawliet · Pull Request #421 · d5/tengo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bugfix: parse expect error when mis match braces #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2023
Merged

bugfix: parse expect error when mis match braces #421

merged 2 commits into from
Apr 23, 2023

Conversation

sailinglawliet
Copy link
Contributor

Change-Id: Iba1ad456d5b020375bb0416f44fb54bc2e346d62

bugfix: parse expect error when mis match braces
c672f2f 
Change-Id: Iba1ad456d5b020375bb0416f44fb54bc2e346d62
@sailinglawliet
Copy link
Contributor Author

image

8000

@sailinglawliet
Copy link
Contributor Author

plz review if u guys got time thx @d5 @geseq

geseq
geseq requested changes Apr 22, 2023
View reviewed changes
Copy link
Collaborator
@geseq geseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. You need to account for the import expression as well

@sailinglawliet
Copy link
Contributor Author

Thanks for the PR. You need to account for the import expression as well

yeah, i see the check failed, but its due to the wrong test cases, ill fix it as well

fix wrong test case in vm_test
5c51fd2 
Change-Id: Idcdaf7ecc93eb61d374249d11282b8286557d30d
@sailinglawliet sailinglawliet requested a review from geseq April 23, 2023 05:00
geseq
geseq approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator
@geseq geseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM

@geseq geseq merged commit f90bc00 into d5:master Apr 23, 2023
@sailinglawliet
Copy link
Contributor Author

Amazing! LGTM

Can u tag a new version plz？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geseq geseq geseq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sailinglawliet @geseq
0