-
Notifications
You must be signed in to change notification settings - Fork 6
Enforce C style #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce C style #51
Conversation
So far, rather benevolent .clang-format
Can I play with |
Are you in such hurry? I still have some stashed changes and I am adding the rules slowly so that I can still reasonably review that the automated formatting have not broken anything. And no, there will be no spaces in function calls ;-). |
Not really in hurry. I'm just asking for general permission to potentially chime in, because I don't like how clang formats some of the things :-)
I would not dare... :-) |
I’m curious about how this change will handle some of the uglier parts of the code I’ve written (mostly the parts with C macros). Perhaps it would be better to refactor these part so they are written more reasonably. |
That's the plan after we clean up/unify/enforce formatting, so that refactoring is not mixed up with formatting changes. |
29a5bfd
to
9291f8a
Compare
9291f8a
to
362dd38
Compare
Now is the right time :-). I think I have covered the most offensive parts (at least for me) and now the C style is enforced so things will only improve™. Summary of changes
I would like to merge this before any further (functional) changes are made to prevent conflicts. |
Convert to a unified C style (enforcing new rules in each commit) with CI-enforced checks.
Changes applied and enforced:
#include
s sorted