8000 feat: Canvas gridline by Ro4052 · Pull Request #1237 · d3fc/d3fc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Canvas gridline #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
< 10000 /div>
Merged
merged 17 commits into from
Mar 27, 2019
Merged

feat: Canvas gridline #1237

merged 17 commits into from
Mar 27, 2019

Conversation

Ro4052
Copy link
Contributor
@Ro4052 Ro4052 commented Mar 8, 2019 •
edited
Loading

#1160 The D3fc annotation package currently only supports SVG. This PR contains an implementation of the the gridline annotation using canvas.

Note: This has been branched off #1235, as the new implementation is required for this component to work. Edit - This PR has now been merged

@ColinEberhardt ColinEberhardt self-requested a review March 8, 2019 13:33
@Ro4052 Ro4052 changed the title Canvas gridline feat: Canvas gridline Mar 13, 2019
@ColinEberhardt
Copy link
Member

Now that #1235 has been merged, I'll take a closer look at this :-)

@Ro4052
Copy link
Contributor Author
Ro4052 commented Mar 20, 2019

That sounds great!

@ColinEberhardt
Copy link
Member
ColinEberhardt commented Mar 22, 2019 •
edited
Loading

Great job, thanks @Ro4052 - one minor point ...

Can you please add to the README file? See the d3fc-series README for how we document svg / canvas

@Ro4052
Copy link
Contributor Author
Ro4052 commented Mar 22, 2019

Hopefully that's roughly what you were looking for with the docs. Let me know of any changes you think are necessary.

@ColinEberhardt ColinEberhardt merged commit 8fd3377 into d3fc:master Mar 27, 2019
@ColinEberhardt
Copy link
Member

Hopefully that's roughly what you were looking for with the docs.
Perfect - thank you!

@Ro4052 Ro4052 deleted the canvas-gridline branch March 27, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinEberhardt ColinEberhardt Awaiting requested review from ColinEberhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ro4052 @ColinEberhardt
0