8000 fix: moved both axis to give them a higher z-order than the plot area by ColinEberhardt · Pull Request #1275 · d3fc/d3fc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: moved both axis to give them a higher z-order than the plot area #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

fix: moved both axis to give them a higher z-order than the plot area #1275

merged 1 commit into from
May 22, 2019

Conversation

ColinEberhardt
Copy link
Member

If you look at examples/move-axis.js it relies on the axes having a higher z-order than the plot area. I can't think of any example where you would want this the other way around.

@ColinEberhardt ColinEberhardt requested review from chrisprice and removed request for chrisprice May 22, 2019 13:57
@ColinEberhardt
Copy link
Member Author

@Ro4052 can you please take a look at this change?

@Ro4052
Copy link
Contributor
Ro4052 commented May 22, 2019 •
edited
Loading

@Ro4052 can you please take a look at this change?

My git diff makes it look like nothing has changed. It hasn't picked up any changes in examples/move-axis.js.

image

@ColinEberhardt ColinEberhardt merged commit 9dcd7db into d3fc:cartesian-updates May 22, 2019
@ColinEberhardt ColinEberhardt deleted the cartesian-updates branch September 21, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ro4052 Ro4052 Ro4052 approved these changes

Assignees
No one assigned
Labels
None yet
Projects 4468
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinEberhardt @Ro4052
0