8000 chore: Set value returned by `PRAGMA user_agent` to r-dbi by elefeint · Pull Request #707 · duckdb/duckdb-r · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 chore: Set value returned by PRAGMA user_agent to r-dbi #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2025
Merged

chore: Set value returned by PRAGMA user_agent to r-dbi #707

merged 4 commits into from
Feb 2, 2025

Conversation

elefeint
Copy link
Contributor

R clients using PRAGMA user_agent historically fell back on the default "cpp" value of duckdb_api. Example output:

duckdb/v1.1.4-dev2005(linux_amd64) cpp

This PR sets an R specific r-dbi value. I used r-dbi as an analogy to jdbc, which indicates both the language and the API. Would another duckdb_api string be more appropriate?

Example output with this PR:

duckdb/v1.1.4-dev2005(linux_amd64) r-dbi

@krlmlr krlmlr changed the title Add r-dbi user-agent chore: Add r-dbi user-agent Dec 26, 2024
@krlmlr krlmlr requested a review from hannes December 26, 2024 21:17
@krlmlr krlmlr changed the title chore: Add r-dbi user-agent chore: Set value returned by PRAGMA user_agent to r-dbi Dec 26, 2024
@elefeint
Copy link
Contributor Author

@krlmlr I merged from main; could you trigger the test run when you get a chance?

@krlmlr krlm 8DE4 lr merged commit bd01478 into duckdb:main Feb 2, 2025
17 checks passed
@krlmlr
Copy link
Collaborator
krlmlr commented Feb 2, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes hannes Awaiting requested review from hannes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elefeint @krlmlr
0