Bump arrow to the version compatible with chrono 0.4.40 #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI we have released a fix in 54.2.1: apache/arrow-rs#7209 |
alamb
reviewed
Feb 27, 2025
Cargo.toml
Outdated
| @@ -28,7 +28,7 @@ byteorder = "1.3" | |||
| calamine = "0.22.0" | |||
| cast = "0.3" | |||
| cc = "1.0" | |||
| chrono = "0.4.22" | |||
| chrono = "0.4.40" | |||
There was a problem hiding this comment.
the hotfix for arrow basically encodes this requirement in arrows cargo.toml
There was a problem hiding this comment.
Ah, your are right. Thanks for catching!
|
Hello! Thanks a lot for the PR! I've included these changes as part of #462, so I'm going to go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an unfortunate collision with the latest chrono crate, the arrow crate before version 54.2.1 doesn't compile. Although the version 54.2.1, which addressed the compatibility issue, is about to be released (
note: at the time of writing this, it's not released yetReleased!!!), it's probably a good idea to bump the versions of chrono and arrow to make sure the compilation error won't happen.c.f.)
ChronoDateExt::quarter()conflicts with chrono v0.4.40 apache/arrow-rs#7196