8000 Make DuckString's constructor public by benjamintli · Pull Request #497 · duckdb/duckdb-rs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make DuckString's constructor public #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By 8000 clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Make DuckString's constructor public #497

merged 1 commit into from
May 23, 2025

Conversation

benjamintli
Copy link
Contributor

When trying to build a scalar function extension in Rust, pulling VARCHARs from the invoke function is quite difficult, as there isn't an easy way to convert duck_string_t into a Rust string. @yutannihilation describes it well here #484.

This PR just removes the (crate) in front of the DuckString constructor.

@Maxxen Maxxen merged commit bb47f26 into duckdb:main May 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjamintli @Maxxen
0