`COLUMNS(x -> <anything>)` treats tokens in `<anything>` as string literals even when not in quotes #16163

soerenwolfers · 2025-02-10T16:44:33Z

What happens?

COLUMNS(x -> <anything>) treats tokens in <anything> as string literals even when not in quotes.

To Reproduce

SELECT COLUMNS(x -> x.type[3] = 't') FROM range(1); -- e.g., user wants to filter for integers, but gets all columns

┌───────┐
│ range │
│ int64 │
├───────┤
│     0 │
└───────┘

SELECT COLUMNS(x -> asdf >= asdf) FROM range(1);

┌───────┐
│ range │
│ int64 │
├───────┤
│     0 │
└───────┘

OS:

Linux

DuckDB Version:

1.2

DuckDB Client:

Python

Hardware:

.

Full Name:

Soeren Wolfers

Affiliation:

G-Research

What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

I have tested with a nightly build

Did you include all relevant data sets for reproducing the issue?

Not applicable - the reproduction does not require a data set

Did you include all code required to reproduce the issue?

Yes, I have

Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?

Yes, I have

The text was updated successfully, but these errors were encountered:

paultiq · 2025-02-10T18:29:33Z

+1.

Another version of this that I was recently fighting with. In this case, I was trying to pass a list into the columns expression:

with q1 as (select ['somerange'] as selected_cols)
    select 
        columns(c->c in selected_cols) from q1, range(10) t(somerange)

selected_cols
[somerange]
...

Yet this had the expected result:

  select 
      columns(c->c in ['somerange'])
      from range(10) t(somerange)

Fixes #16163

Fix duckdb/duckdb#16163: COLUMNS should not treat identifiers as strings (duckdb/duckdb#16193) Only delete test directory when `--test-temp-dir` is not specified (duckdb/duckdb#16192) unified names for duckdb-extensions (duckdb/duckdb#16179)

soerenwolfers added the needs triage label Feb 10, 2025

soerenwolfers changed the title ~~SELECT COLUMNS(x -> x.name[1] = 'x') FROM range(1); treats x.name as string literal~~ COLUMNS(x -> <anything>) treats <anystring> as string literal even when it isn't in quotes Feb 10, 2025

soerenwolfers changed the title ~~COLUMNS(x -> <anything>) treats <anystring> as string literal even when it isn't in quotes~~ COLUMNS(x -> <anything>) treats tokens in <anything> as string literals even when not in quotes Feb 10, 2025

szarnyasg added the reproduced label Feb 10, 2025

duckdblabs-bot removed the needs triage label Feb 10, 2025

Mytherin added a commit to Mytherin/duckdb that referenced this issue Feb 11, 2025

Fix duckdb#16163: COLUMNS should not treat identifiers as strings

36f2c7c

Mytherin mentioned this issue Feb 11, 2025

Fix #16163: COLUMNS should not treat identifiers as strings #16193

Merged

Mytherin closed this as completed in #16193 Feb 12, 2025

Mytherin added a commit that referenced this issue Feb 12, 2025

Fix #16163: COLUMNS should not treat identifiers as strings (#16193)

0aefc1e

Fixes #16163

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`COLUMNS(x -> <anything>)` treats tokens in `<anything>` as string literals even when not in quotes #16163

`COLUMNS(x -> <anything>)` treats tokens in `<anything>` as string literals even when not in quotes #16163

Uh oh!

COLUMNS(x -> <anything>) treats tokens in <anything> as string literals even when not in quotes #16163

COLUMNS(x -> <anything>) treats tokens in <anything> as string literals even when not in quotes #16163

Comments

Uh oh!

What happens?

To Reproduce

OS:

DuckDB Version:

DuckDB Client:

Hardware:

Full Name:

Affiliation:

What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

Did you include all relevant data sets for reproducing the issue?

Did you include all code required to reproduce the issue?

Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?

Uh oh!

Uh oh!

`COLUMNS(x -> <anything>)` treats tokens in `<anything>` as string literals even when not in quotes #16163

`COLUMNS(x -> <anything>)` treats tokens in `<anything>` as string literals even when not in quotes #16163