8000 Fix #7582 - correctly set "last_offset" in InitializeScanWithOffset and turn assertion into run-time check by Mytherin · Pull Request #7586 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #7582 - correctly set "last_offset" in InitializeScanWithOffset and turn assertion into run-time check #7586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

Fix #7582 - correctly set "last_offset" in InitializeScanWithOffset and turn assertion into run-time check #7586

merged 1 commit into from
May 19, 2023

Conversation

Mytherin
Copy link
Collaborator

Fixes #7582

This issue pops up when inserting several small lists into a table (small enough to not trigger the WAL auto-checkpoint). The system tries to commit a subset of the lists using InitializeScanWithOffset - but the scan was not correctly initializing last_offset leading to reading out of bounds on the child list.

This triggers an assertion which this PR has also turned into an InternalException.

@Mytherin Mytherin mentioned this pull request May 19, 2023
Closed
2 tasks
@Mytherin Mytherin merged commit 67e69a5 into duckdb:master May 19, 2023
@Mytherin Mytherin deleted the issue7582 branch July 5, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EXC_BAD_ACCESS during insert
1 participant
@Mytherin
0