8000 Remove all C-style casts and add clang-tidy rule to forbid them by Mytherin · Pull Request #7656 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove all C-style casts and add clang-tidy rule to forbid them #7656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
May 24, 2023
Merged

Remove all C-style casts and add clang-tidy rule to forbid them #7656

merged 30 commits into from
May 24, 2023
+3,855 −3,263

Conversation

Mytherin
Copy link
Collaborator

Follow-up from #6967

This PR removes all remaining C-style casts from the codebase and adds the cppcoreguidelines-pro-type-cstyle-cast clang-tidy rule that forbid all usage of C-style casts. Instead the dedicated Cast methods, [const]_data_ptr_cast, [const]_char_ptr_cast, or reinterpret_cast should be used instead.

Aside from just replacing casts and adding more Cast methods, this PR makes the following changes:

  • Adds the UnifiedVectorFormat::GetData method that should be used to get the array data of a UnifiedVectorFormat object
  • BaseExpression::Equals works with references instead of C-pointers
  • The CastPointerToValue should be used to cast a pointer to its uintptr_t value - instead of just casting the pointer
  • Pointers in several methods are made const
  • Many methods in the Transformer are moved to using references instead of pointers, and the PGCast and PGPointerCast methods are added that cast to a reference/optional_ptr respectively

Also includes #7650

Mytherin added 30 commits May 18, 2023 21:22
10000
@Mytherin
Remove C-style casts and add clang-tidy rule (WIP)
eddc926
@Mytherin
Remove clang-tidy rule again for now
5188232
@Mytherin
Revert Makefile
6b9112f
@Mytherin
Transformer - avoid using C-style casts, and move to using references…
19f65c5 
… and optional_ptr
@Mytherin
Get rid of more C-style casts
45846c7
@Mytherin
UnifiedVectorFormat::GetData
2e09719
@Mytherin
Many more C-style cast removals
4e38e6f
@Mytherin
More UnifiedVectorFormat::GetData and other casts
5fcb727
@Mytherin
Format and HyperLogLog avoid using void*
be6d125
@Mytherin
Tidy-fixes in date_part
39d2451
@Mytherin
Many more C-style casts
4a13e8a
@Mytherin
data_ptr_cast
2194b6f
@Mytherin
const_data_ptr_cast
435606b
@Mytherin
char* and const char* casts
c8ae629
@Mytherin
Missing dereference
c124fc0
@Mytherin
Remove C-style casts from vector and others
88ace2d
@Mytherin
Even more C-style cast removal
1821ba4
@Mytherin
Turn resizable buffer ptr into data_ptr_t, and remove casts from Parq…
8d4e3fb 
…uet reader
@Mytherin
Less c-style casts in the Parquet extension
f4bf9bd
@Mytherin
Revert R changes
26651f2
@Mytherin
Remove extra ;
14a5d11
@Mytherin
CastNoConst
1256895
@Mytherin
Format fix
281057c
@Mytherin
Merge branch 'master' into moreclangtidy
1145997
@Mytherin
Use reinterpret_cast in Cast headers, and more cast removal in Python…
a23725a 
… client
@Mytherin
Python - move unicode methods into separate functions
bfe1fbd
@Mytherin
Move these defines to header
91a585d
@Mytherin
Fix sql auto complete extension
4386429
@Mytherin
Merge branch 'extfix' into moreclangtidy
81806e9
@Mytherin
Coverage fixes
0c5ecc3
@Mytherin Mytherin merged commit faf428b into duckdb:master May 24, 2023
@Mytherin Mytherin deleted the moreclangtidy branch July 5, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mytherin
0